.
Created attachment 238622 [details] WIP
Comment on attachment 238622 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=238622&action=review > Source/JavaScriptCore/replay/scripts/tests/expected/generate-enum-encoding-helpers.json-TestReplayInputs.cpp:181 > + if (enumString == "Mouse") > + enumValue = static_cast<WebCore::PlatformEvent::Type>(enumValue | WebCore::PlatformEvent::Mouse); > + if (enumString == "Key") Nit: Should be an else/if chain.
Created attachment 238746 [details] Patch
This patch modifies the WEB_REPLAY inputs generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-input-generator-tests --reset-results`)
Comment on attachment 238746 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238746&action=review r=me > Source/JavaScriptCore/ChangeLog:11 > + Change the generator to not require an explicit size if an enum is declared inside a struct or class definition. In that case, it must pull in headers since scoped enums can't be Style: wrap line earlier. > Source/JavaScriptCore/replay/scripts/tests/expected/generate-enum-encoding-helpers.json-TestReplayInputs.cpp:178 > + for (String enumString : enumStrings) { Nit: Unrelated to your changes, but I wonder if "for (const String& : ...)" would be better.
Committed r174863: <http://trac.webkit.org/changeset/174863>
*** Bug 136296 has been marked as a duplicate of this bug. ***