Bug 137083 - Web Inspector: persist probe samples in the probe details section across subsequent replays
Summary: Web Inspector: persist probe samples in the probe details section across subs...
Status: RESOLVED LATER
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 137162
Blocks: 137078
  Show dependency tree / graph
 
Reported: 2014-09-24 16:10 PDT by Brian Burg
Modified: 2017-07-10 14:01 PDT (History)
2 users (show)

See Also:

Attachments
WIP (25.83 KB, patch)
2014-09-24 16:11 PDT, Brian Burg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2014-09-24 16:10:01 PDT 
This code has been sitting around a long time :)
Comment 1 Radar WebKit Bug Importer 2014-09-24 16:11:04 PDT 
<rdar://problem/18447807>
Comment 2 Brian Burg 2014-09-24 16:11:33 PDT 
Created attachment 238618 [details]
WIP
Comment 3 Timothy Hatcher 2014-09-24 21:37:20 PDT 
Comment on attachment 238618 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=238618&action=review

> Source/WebInspectorUI/UserInterface/Models/ProbeSetReplayDataFrame.js:54
> +        return "%d,%d,%d".format(this.position.segmentOffset, this.position.inputOffset, this.counterValue);

Eh. Just use concat (+)?
Comment 4 Blaze Burg 2017-07-10 14:01:27 PDT 
Closing web replay-related bugs until we resume working on the feature again.