Bug 137079 - Web Inspector: don't suppress breakpoints when emptying the call stack prior to replay
Summary: Web Inspector: don't suppress breakpoints when emptying the call stack prior ...
Status: RESOLVED LATER
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 137078
  Show dependency tree / graph
 
Reported: 2014-09-24 15:48 PDT by Brian Burg
Modified: 2017-07-10 14:01 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2014-09-24 15:48:38 PDT 
The ReplayManager tries to temporarily suppress breakpoints before (re-)starting replay and resumes the debugger in case the debugger is paused. This interacts poorly with time-indexed outputs because starting playback will race with unsuppressing breakpoints, and some breakpoint hits may be missed.

Instead, we should probably just issue Debugger.stepOut commands until nothing is left in the call stack, and then restart replay.

There may be some way to blow over the call stack using exceptions or something, but this could have a lot of unwanted side effects in the UI.
Comment 1 Timothy Hatcher 2014-09-24 21:49:42 PDT 
Maybe the best fix on on the backend? ReplayAgent can talk directly to the debugger and only pause when needed.
Comment 2 Radar WebKit Bug Importer 2014-09-24 21:49:50 PDT 
<rdar://problem/18450892>
Comment 3 BJ Burg 2017-07-10 14:01:26 PDT 
Closing web replay-related bugs until we resume working on the feature again.