Bug 137053 – WebKit top of tree sources won't build in 10.9 w/ Xcode 6.0.1

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[David Gatwood]

With a stock (non-Apple-Internal) installation of Xcode 6.0.1, on 10.9.5, using a current top-of-tree SVN checkout from webkit.org, if I open the provide WebKit.xcworkspace and build it, I get a build failure in the component "llvmForJSC" because the following headers are not present:

    #include <llvm-c/Analysis.h>
    #include <llvm-c/BitReader.h>
    #include <llvm-c/Core.h>
    #include <llvm-c/Disassembler.h>
    #include <llvm-c/ExecutionEngine.h>
    #include <llvm-c/Initialization.h>
    #include <llvm-c/Linker.h>
    #include <llvm-c/Target.h>
    #include <llvm-c/TargetMachine.h>
    #include <llvm-c/Transforms/IPO.h>
    #include <llvm-c/Transforms/PassManagerBuilder.h>
    #include <llvm-c/Transforms/Scalar.h>

These headers were also not present in the public version of Xcode 5.1.1, so this isn't an Xcode regression (or at least not a recent one).

I'm getting a similar failure from

    #include <WebCore/PlatformExportMacros.h>

in the DumpRenderTree library.

And in both of those subprojects, I'm also seeing the following warnings:

    Base.xcconfig line 23: Unable to find included file "<DEVELOPER_DIR>/AppleInternal/XcodeConfig/AspenFamily.xcconfig"
    Base.xcconfig line 24: Unable to find included file "../../../../Internal/Configurations/HaveInternalSDK.xcconfig"

The webkit.org site (https://www.webkit.org/building/build.html) says that you can build WebKit using the provided xcworkspace, but I'm starting to suspect that this is not actually the case, or at least not without installing a bunch of external bits (llvm headers) that are not mentioned in the page that describes checking out the sources (https://www.webkit.org/building/checkout.html).

[David Gatwood]

Err.. the *provided* xcworkspace file....  Sorry about the typo.

[Alexey Proskuryakov]

Does build-webkit script work for you? I'm also not sure how the workspace could work.

[Mark Rowe (bdash)]

It's required that you build at least once via build-webkit before building via other means (e.g., make or from within Xcode). build-webkit extracts both the WebKitSystemInterface and LLVM headers / libraries from WebKitLibraries into the build directory where they're on the relevant search paths.

[David Gatwood]

Ah.  That's good to know.  In that case, please consider this a request for an update to the docs—specifically, mention that here:

   https://www.webkit.org/building/build.html


Thanks.

[Alexey Proskuryakov]

David, would you be willing to submit a patch? The documentation is in repository, just like the source code.

[David Gatwood]

Yeah.  It's still not building for me.  I'm digging in further.

[David Gatwood]

I think I figured it out.  Xcode was doing a debug build, whereas "build-webkit" defaults to a Release build, so the build products weren't in the right place.  I'm doing a build-webkit --debug now.  Assuming that resolves the problem, I'll clarify the instructions and upload a patch for the docs.

[David Gatwood]

Created attachment 238641 [details]
Patch to clarify steps for building with Xcode, etc.

Patch attached.  I did a little bit of cleanup in other parts of the page to reduce confusion and clutter as well.  Feel free to incorporate as much or as little of this as you see fit.

[Alexey Proskuryakov]

Thank you David, landed (with tweaks) in <http://trac.webkit.org/r174033>.

I restored the rounded rectangle, as this is the style that we use across multiple pages.

(In reply to comment #3)
> It's required that you build at least once via build-webkit before building via other means (e.g., make or from within Xcode). build-webkit extracts both the WebKitSystemInterface and LLVM headers / libraries from WebKitLibraries into the build directory where they're on the relevant search paths.

Can we fix this? It used to be that the build pre-actions in the All Source and All Source (target WebProcess) schemes did everything that was needed.

(In reply to comment #10)
> (In reply to comment #3)
> > It's required that you build at least once via build-webkit before building via other means (e.g., make or from within Xcode). build-webkit extracts both the WebKitSystemInterface and LLVM headers / libraries from WebKitLibraries into the build directory where they're on the relevant search paths.
> 
> Can we fix this? It used to be that the build pre-actions in the All Source and All Source (target WebProcess) schemes did everything that was needed.

It seems like all it would take, at least for OS X builds, is to change the script to pass the --wksi and --llvm options to copy-webkitlibraries-to-product-directory.

Reopening to address the issue rather than document around it.

Created attachment 238765 [details]
Pass --wksi and --lvm to copy-webkitlibraries-to-product-directory in the build pre-actions

Fixed in <http://trac.webkit.org/r174034>.