Bug 137048 - Implement WKPageIsPlayingAudio()
Summary: Implement WKPageIsPlayingAudio()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ada Chan
URL:
Keywords:
Depends on: 137218
Blocks:
  Show dependency tree / graph
 
Reported: 2014-09-23 16:23 PDT by Ada Chan
Modified: 2014-10-08 11:23 PDT (History)
4 users (show)

See Also:

Attachments
Patch: Implemented WKPageIsPlayingAudio() and the TestWebKitAPI test for it. (174.58 KB, patch)
2014-10-06 22:08 PDT, Ada Chan 		no flags Details | Formatted Diff | Diff
Updated patch (174.58 KB, patch)
2014-10-07 10:41 PDT, Ada Chan 		no flags Details | Formatted Diff | Diff
Updated patch: this time using git diff. (172.53 KB, patch)
2014-10-07 11:46 PDT, Ada Chan 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ada Chan 2014-09-23 16:23:42 PDT 
Implement WKPageIsPlayingAudio().
Comment 1 Ada Chan 2014-10-06 22:08:24 PDT 
Created attachment 239386 [details]
Patch: Implemented WKPageIsPlayingAudio() and the TestWebKitAPI test for it.
Comment 2 Ada Chan 2014-10-07 10:41:10 PDT 
Created attachment 239416 [details]
Updated patch

Maybe I shouldn't have passed in --binary when creating the patch?  Attached updated patch generated without --binary.
Comment 3 Ada Chan 2014-10-07 11:46:22 PDT 
Created attachment 239421 [details]
Updated patch: this time using git diff.
Comment 4 Darin Adler 2014-10-07 21:55:36 PDT 
Comment on attachment 239421 [details]
Updated patch: this time using git diff.

View in context: https://bugs.webkit.org/attachment.cgi?id=239421&action=review

> Tools/TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:77
> +    WKRetainPtr<WKContextRef> context(AdoptWK, WKContextCreate());

Please use the adoptWK() function instead of the AdoptWK constructor, since we’d like to delete it eventually.
Comment 5 Ada Chan 2014-10-08 11:10:00 PDT 
(In reply to comment #4)
> (From update of attachment 239421 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=239421&action=review
> 
> > Tools/TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:77
> > +    WKRetainPtr<WKContextRef> context(AdoptWK, WKContextCreate());
> 
> Please use the adoptWK() function instead of the AdoptWK constructor, since we’d like to delete it eventually.

I've changed the code to use adoptWK().

Thanks for reviewing!
Comment 6 Ada Chan 2014-10-08 11:23:13 PDT 
Committed:
http://trac.webkit.org/changeset/174463