RESOLVED FIXED 137048
Implement WKPageIsPlayingAudio() 
https://bugs.webkit.org/show_bug.cgi?id=137048
Summary Implement WKPageIsPlayingAudio()
Ada Chan
Reported 2014-09-23 16:23:42 PDT
Implement WKPageIsPlayingAudio().
Attachments
Patch: Implemented WKPageIsPlayingAudio() and the TestWebKitAPI test for it. (174.58 KB, patch)
2014-10-06 22:08 PDT, Ada Chan 		no flags
DetailsFormatted DiffDiff
Updated patch (174.58 KB, patch)
2014-10-07 10:41 PDT, Ada Chan 		no flags
DetailsFormatted DiffDiff
Updated patch: this time using git diff. (172.53 KB, patch)
2014-10-07 11:46 PDT, Ada Chan 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ada Chan
Comment 1 2014-10-06 22:08:24 PDT
Created attachment 239386 [details] Patch: Implemented WKPageIsPlayingAudio() and the TestWebKitAPI test for it.
Ada Chan
Comment 2 2014-10-07 10:41:10 PDT
Created attachment 239416 [details] Updated patch Maybe I shouldn't have passed in --binary when creating the patch? Attached updated patch generated without --binary.
Ada Chan
Comment 3 2014-10-07 11:46:22 PDT
Created attachment 239421 [details] Updated patch: this time using git diff.
Darin Adler
Comment 4 2014-10-07 21:55:36 PDT
Comment on attachment 239421 [details] Updated patch: this time using git diff. View in context: https://bugs.webkit.org/attachment.cgi?id=239421&action=review > Tools/TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:77 > + WKRetainPtr<WKContextRef> context(AdoptWK, WKContextCreate()); Please use the adoptWK() function instead of the AdoptWK constructor, since we’d like to delete it eventually.
Ada Chan
Comment 5 2014-10-08 11:10:00 PDT
(In reply to comment #4) > (From update of attachment 239421 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=239421&action=review > > > Tools/TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:77 > > + WKRetainPtr<WKContextRef> context(AdoptWK, WKContextCreate()); > > Please use the adoptWK() function instead of the AdoptWK constructor, since we’d like to delete it eventually. I've changed the code to use adoptWK(). Thanks for reviewing!
Ada Chan
Comment 6 2014-10-08 11:23:13 PDT
Committed: http://trac.webkit.org/changeset/174463
Note You need to log in before you can comment on or make changes to this bug.