Bug 137038 - Web Inspector: Automatic Inspection should continue once all breakpoints are loaded
Summary: Web Inspector: Automatic Inspection should continue once all breakpoints are ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-09-23 12:44 PDT by Joseph Pecoraro
Modified: 2014-09-26 16:25 PDT (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (22.49 KB, patch)
2014-09-23 12:54 PDT, Joseph Pecoraro 		timothy: review+
joepeck: commit-queue-
Details | Formatted Diff | Diff
[PATCH] Proposed Fix (22.50 KB, patch)
2014-09-23 14:05 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-09-23 12:44:45 PDT 
Currently Automatic Inspection pauses immediately. This gives the frontend time to send to the backend all the breakpoints it knows about, so by the time the backend continues it has all the breakpoints loaded.

Instead of enforcing this automatic pause on auto-inspect, we should just pause the JSContext until all the frontend's state is loaded, including all the breakpoints.
Comment 1 Radar WebKit Bug Importer 2014-09-23 12:45:36 PDT 
<rdar://problem/18429875>
Comment 2 Joseph Pecoraro 2014-09-23 12:54:13 PDT 
Created attachment 238559 [details]
[PATCH] Proposed Fix
Comment 3 Timothy Hatcher 2014-09-23 13:33:07 PDT 
Comment on attachment 238559 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=238559&action=review

> Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggable.cpp:94
> +void RemoteInspectorDebuggable::unpauseInspectorInitialized()

The wording here is kind of confusing. Lets go with something like: unpauseForInitializedInspector.
Comment 4 Joseph Pecoraro 2014-09-23 14:05:09 PDT 
Created attachment 238570 [details]
[PATCH] Proposed Fix

See how this looks on the bots.
Comment 5 WebKit Commit Bot 2014-09-26 16:25:22 PDT 
Comment on attachment 238570 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 238570

Committed r174028: <http://trac.webkit.org/changeset/174028>
Comment 6 WebKit Commit Bot 2014-09-26 16:25:25 PDT 
All reviewed patches have been landed.  Closing bug.