RESOLVED FIXED137038
Web Inspector: Automatic Inspection should continue once all breakpoints are loaded 
https://bugs.webkit.org/show_bug.cgi?id=137038
Summary Web Inspector: Automatic Inspection should continue once all breakpoints are ...
Joseph Pecoraro
Reported 2014-09-23 12:44:45 PDT
Currently Automatic Inspection pauses immediately. This gives the frontend time to send to the backend all the breakpoints it knows about, so by the time the backend continues it has all the breakpoints loaded. Instead of enforcing this automatic pause on auto-inspect, we should just pause the JSContext until all the frontend's state is loaded, including all the breakpoints.
Attachments
[PATCH] Proposed Fix (22.49 KB, patch)
2014-09-23 12:54 PDT, Joseph Pecoraro 		timothy: review+
joepeck: commit-queue-
DetailsFormatted DiffDiff
[PATCH] Proposed Fix (22.50 KB, patch)
2014-09-23 14:05 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-09-23 12:45:36 PDT
<rdar://problem/18429875>
Joseph Pecoraro
Comment 2 2014-09-23 12:54:13 PDT
Created attachment 238559 [details] [PATCH] Proposed Fix
Timothy Hatcher
Comment 3 2014-09-23 13:33:07 PDT
Comment on attachment 238559 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=238559&action=review > Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggable.cpp:94 > +void RemoteInspectorDebuggable::unpauseInspectorInitialized() The wording here is kind of confusing. Lets go with something like: unpauseForInitializedInspector.
Joseph Pecoraro
Comment 4 2014-09-23 14:05:09 PDT
Created attachment 238570 [details] [PATCH] Proposed Fix See how this looks on the bots.
WebKit Commit Bot
Comment 5 2014-09-26 16:25:22 PDT
Comment on attachment 238570 [details] [PATCH] Proposed Fix Clearing flags on attachment: 238570 Committed r174028: <http://trac.webkit.org/changeset/174028>
WebKit Commit Bot
Comment 6 2014-09-26 16:25:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.