Bug 137036 - Have CSS classes' methods return more references
Summary: Have CSS classes' methods return more references
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-23 12:34 PDT by Chris Dumez
Modified: 2014-09-23 18:45 PDT (History)
3 users (show)

See Also:

Attachments
Patch (10.66 KB, patch)
2014-09-23 12:37 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (17.40 KB, patch)
2014-09-23 14:48 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-09-23 12:34:55 PDT 
Have CSS classes' methods return more references instead of pointers.
Comment 1 Chris Dumez 2014-09-23 12:37:31 PDT 
Created attachment 238558 [details]
Patch
Comment 2 Chris Dumez 2014-09-23 14:48:25 PDT 
Created attachment 238573 [details]
Patch
Comment 3 Ryosuke Niwa 2014-09-23 18:04:17 PDT 
Comment on attachment 238573 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238573&action=review

> Source/WebCore/inspector/InspectorStyleSheet.cpp:849
> -    RefPtr<CSSRuleSourceData> sourceData = ruleSourceDataFor(rule->style());
> +    RefPtr<CSSRuleSourceData> sourceData = ruleSourceDataFor(&rule->style());

Can't we use Ref instead?

> Source/WebCore/inspector/InspectorStyleSheet.cpp:932
> -    RefPtr<CSSRuleSourceData> sourceData = ruleSourceDataFor(rule->style());
> +    RefPtr<CSSRuleSourceData> sourceData = ruleSourceDataFor(&rule->style());

Ditto.
Comment 4 WebKit Commit Bot 2014-09-23 18:45:46 PDT 
Comment on attachment 238573 [details]
Patch

Clearing flags on attachment: 238573

Committed r173905: <http://trac.webkit.org/changeset/173905>
Comment 5 WebKit Commit Bot 2014-09-23 18:45:51 PDT 
All reviewed patches have been landed.  Closing bug.