Bug 137031 - [Tools] git-commit uses wrong ChangeLog when run from a subdirectory
Summary: [Tools] git-commit uses wrong ChangeLog when run from a subdirectory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-23 11:05 PDT by Jer Noble
Modified: 2014-09-23 13:54 PDT (History)
0 users

See Also:

Attachments
Patch (1.53 KB, patch)
2014-09-23 11:09 PDT, Jer Noble 		joepeck: review+
Details | Formatted Diff | Diff
Patch (3.44 KB, patch)
2014-09-23 11:11 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2014-09-23 11:05:39 PDT 
[Tools] git-commit uses wrong ChangeLog when run from a subdirectory
Comment 1 Jer Noble 2014-09-23 11:09:05 PDT 
Created attachment 238548 [details]
Patch
Comment 2 Jer Noble 2014-09-23 11:11:19 PDT 
Created attachment 238549 [details]
Patch
Comment 3 Joseph Pecoraro 2014-09-23 13:10:43 PDT 
Comment on attachment 238548 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238548&action=review

r=me!

> Tools/Scripts/commit-log-editor:155
> +@changeLogs = map { $ENV{GIT_PREFIX} . $_} @changeLogs if (isGit());

Nit: Should have a space at the end of the inside block
Nit: Unnecessary parens around the if condition when it is at the end of the line:

    @changeLogs = map { $ENV{GIT_PREFIX} . $_ } @changeLogs if isGit();
Comment 4 Jer Noble 2014-09-23 13:54:28 PDT 
Committed r173887: <http://trac.webkit.org/changeset/173887>