Bug 136993 – bmalloc: Allocation should be more precise

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Geoffrey Garen]

bmalloc: Allocation should be more precise

[Geoffrey Garen]

Created attachment 238450 [details]
Patch

[Geoffrey Garen]

Created attachment 238451 [details]
Patch

[WebKit Commit Bot]

Attachment 238451 [details] did not pass style-queue:


ERROR: Source/bmalloc/bmalloc/Heap.cpp:237:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/bmalloc/bmalloc/Heap.cpp:262:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Geoffrey Garen]

Created attachment 238455 [details]
Patch

[Geoffrey Garen]

Created attachment 238456 [details]
Patch

[WebKit Commit Bot]

Attachment 238456 [details] did not pass style-queue:


ERROR: Source/bmalloc/bmalloc/Heap.cpp:237:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/bmalloc/bmalloc/Heap.cpp:262:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Geoffrey Garen]

Created attachment 238457 [details]
Patch

[WebKit Commit Bot]

Attachment 238457 [details] did not pass style-queue:


ERROR: Source/bmalloc/bmalloc/Heap.cpp:237:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/bmalloc/bmalloc/Heap.cpp:262:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Geoffrey Garen]

Created attachment 238511 [details]
Patch

[WebKit Commit Bot]

Attachment 238511 [details] did not pass style-queue:


ERROR: Source/bmalloc/bmalloc/Heap.cpp:237:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/bmalloc/bmalloc/Heap.cpp:262:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Gavin Barraclough]

Comment on attachment 238457 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238457&action=review

r+ with discussed scavenge changes.

> Source/bmalloc/ChangeLog:74
> +        (bmalloc::Heap::allocateMediumLineSlowCase): Deleted. Foled into the

Folded?

> Source/bmalloc/bmalloc/Heap.cpp:190
> +void Heap::refillMediumBumpRangeCache(std::lock_guard<StaticMutex>& lock, size_t sizeClass, MediumBumpRangeCache& rangeCache)

Much duplication! so copy!

> Source/bmalloc/bmalloc/Heap.cpp:201
> +    for (size_t lineNumber = 0; lineNumber < end; ++lineNumber) {

Could be worth a comment on these two loops – outer loop finds new disjoint ranges, inner loop coalesces additional lines into a range.

> Source/bmalloc/bmalloc/Heap.cpp:211
> +        while (++lineNumber < end) {

Could be worth a comment on these two loops – outer loop finds new disjoint ranges, inner loop coalesces additional lines into a range.

> Source/bmalloc/bmalloc/Heap.cpp:250
> +MediumPage* Heap::allocateMediumPage(std::lock_guard<StaticMutex>& lock, size_t sizeClass)

Much duplication! so copy!

> Source/bmalloc/bmalloc/Heap.cpp:297
> +void Heap::deallocateMediumLine(std::lock_guard<StaticMutex>& lock, MediumLine* line)

Much duplication! so copy!

[Geoffrey Garen]

Committed r173881: <http://trac.webkit.org/changeset/173881>