Bug 136991 - Update HTMLMediaElement logging
Summary: Update HTMLMediaElement logging
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-21 18:45 PDT by Eric Carlson
Modified: 2014-09-22 08:51 PDT (History)
2 users (show)

See Also:

Attachments
Proposed patch. (44.58 KB, patch)
2014-09-21 18:52 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2014-09-21 18:45:19 PDT 
Some of the logging in HTMLMediaElement does not log 'this', making it difficult to use when a page has multiple media elements.
Comment 1 Eric Carlson 2014-09-21 18:52:10 PDT 
Created attachment 238443 [details]
Proposed patch.
Comment 2 Alexey Proskuryakov 2014-09-21 18:57:16 PDT 
Comment on attachment 238443 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=238443&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:673
> +    LOG(Media, "HTMLMediaElement::removedFrom(%p)", this);

I'd log this as HTMLMediaElement %p removedFrom", to make it clear that it's not an argument. Ditto elsewhere.
Comment 3 Eric Carlson 2014-09-22 08:14:50 PDT 
(In reply to comment #2)
> (From update of attachment 238443 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=238443&action=review
> 
> > Source/WebCore/html/HTMLMediaElement.cpp:673
> > +    LOG(Media, "HTMLMediaElement::removedFrom(%p)", this);
> 
> I'd log this as HTMLMediaElement %p removedFrom", to make it clear that it's not an argument. Ditto elsewhere.

All "Media" logging uses this pattern. I don't think there is much danger of it being mistaken for an argument because only 'this' is in parenthesis, so I will leave it as is for now at least.

Thanks for the review!
Comment 4 WebKit Commit Bot 2014-09-22 08:51:33 PDT 
Comment on attachment 238443 [details]
Proposed patch.

Clearing flags on attachment: 238443

Committed r173838: <http://trac.webkit.org/changeset/173838>
Comment 5 WebKit Commit Bot 2014-09-22 08:51:35 PDT 
All reviewed patches have been landed.  Closing bug.