Bug 136966 - build.webkit.org/dashboard: Pending builds don't show up when there is a commit with no comments
Summary: build.webkit.org/dashboard: Pending builds don't show up when there is a comm...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-19 16:55 PDT by Alexey Proskuryakov
Modified: 2014-09-19 19:44 PDT (History)
3 users (show)

See Also:

Attachments
proposed fix (2.17 KB, patch)
2014-09-19 16:59 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-09-19 16:55:08 PDT 
There is an exception raised when description is empty.
Comment 1 Alexey Proskuryakov 2014-09-19 16:59:24 PDT 
Created attachment 238399 [details]
proposed fix
Comment 2 Daniel Bates 2014-09-19 17:56:27 PDT 
Comment on attachment 238399 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=238399&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:105
> -        if (parsedDescription.firstChild.className === "changes") {
> +        if (parsedDescription.firstChild && parsedDescription.firstChild.className === "changes") {

We may want to consider caching parsedDescription.firstChild in a local variable to avoid computing it again since we reference it four times in this function.
Comment 3 WebKit Commit Bot 2014-09-19 19:44:34 PDT 
Comment on attachment 238399 [details]
proposed fix

Clearing flags on attachment: 238399

Committed r173786: <http://trac.webkit.org/changeset/173786>
Comment 4 WebKit Commit Bot 2014-09-19 19:44:37 PDT 
All reviewed patches have been landed.  Closing bug.