RESOLVED FIXED136966
build.webkit.org/dashboard: Pending builds don't show up when there is a commit with no comments 
https://bugs.webkit.org/show_bug.cgi?id=136966
Summary build.webkit.org/dashboard: Pending builds don't show up when there is a comm...
Alexey Proskuryakov
Reported 2014-09-19 16:55:08 PDT
There is an exception raised when description is empty.
Attachments
proposed fix (2.17 KB, patch)
2014-09-19 16:59 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2014-09-19 16:59:24 PDT
Created attachment 238399 [details] proposed fix
Daniel Bates
Comment 2 2014-09-19 17:56:27 PDT
Comment on attachment 238399 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=238399&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:105 > - if (parsedDescription.firstChild.className === "changes") { > + if (parsedDescription.firstChild && parsedDescription.firstChild.className === "changes") { We may want to consider caching parsedDescription.firstChild in a local variable to avoid computing it again since we reference it four times in this function.
WebKit Commit Bot
Comment 3 2014-09-19 19:44:34 PDT
Comment on attachment 238399 [details] proposed fix Clearing flags on attachment: 238399 Committed r173786: <http://trac.webkit.org/changeset/173786>
WebKit Commit Bot
Comment 4 2014-09-19 19:44:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.