Bug 136930 - EWS doesn't run JSC tests, and it should.
Summary: EWS doesn't run JSC tests, and it should.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jake Nielsen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-18 14:53 PDT by Jake Nielsen
Modified: 2014-10-31 11:54 PDT (History)
7 users (show)

See Also:


Attachments
Patch (3.47 KB, patch)
2014-09-18 14:59 PDT, David Farler
ap: review-
dfarler: commit-queue-
Details | Formatted Diff | Diff
Quick-and-dirty test. Don't mind me! (52.93 KB, patch)
2014-10-01 15:47 PDT, Jake Nielsen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jake Nielsen 2014-09-18 14:53:18 PDT
See runtests.py:

        if not self._options.non_interactive:
            # FIXME: We should teach the commit-queue and the EWS how to run these tests.

rdar://problem/18231364
Comment 1 David Farler 2014-09-18 14:59:54 PDT
Created attachment 238324 [details]
Patch
Comment 2 Geoffrey Garen 2014-09-18 15:04:01 PDT
Comment on attachment 238324 [details]
Patch

r=me
Comment 3 David Farler 2014-09-18 15:04:57 PDT
This was Jake's patch, bit of a git config snafu there. Thanks ggaren for the review.
Comment 4 Alexey Proskuryakov 2014-09-18 17:42:23 PDT
Comment on attachment 238324 [details]
Patch

As discussed in person, there is a lot more to this. We need to compare results with a clean run to not complain about pre-existing issues, and we need to combine overall results.
Comment 5 Jake Nielsen 2014-10-01 15:47:39 PDT
Created attachment 239060 [details]
Quick-and-dirty test. Don't mind me!