Bug 136913 - Incorrect pending API request URL when loading an HTML string
Summary: Incorrect pending API request URL when loading an HTML string
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 136916
  Show dependency treegraph
Reported: 2014-09-18 01:27 PDT by Carlos Garcia Campos
Modified: 2014-09-18 10:37 PDT (History)
2 users (show)

See Also:

Patch (1.49 KB, patch)
2014-09-18 01:29 PDT, Carlos Garcia Campos
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2014-09-18 01:27:45 PDT
The check to decide whether to use the given baseURL or about:blank is wrong there:

String pendingAPIRequestURL = baseURL.isEmpty() ? baseURL : ASCIILiteral("about:blank");

It should be the opposite.
Comment 1 Carlos Garcia Campos 2014-09-18 01:29:48 PDT
Created attachment 238296 [details]

Trivial fix
Comment 2 Alexey Proskuryakov 2014-09-18 09:20:47 PDT
Comment on attachment 238296 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=238296&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:795
> +    m_pageLoadState.setPendingAPIRequestURL(transaction, !baseURL.isEmpty() ? baseURL : ASCIILiteral("about:blank"));


Can this be tested?
Comment 3 Alexey Proskuryakov 2014-09-18 09:22:55 PDT
Comment on attachment 238296 [details]

I see, it's tested in a patch for the bug blocked by this one.
Comment 4 Carlos Garcia Campos 2014-09-18 10:37:02 PDT
Committed r173726: <http://trac.webkit.org/changeset/173726>