Bug 136909 - Occasional unreproducible crashes in MessageReceiverMap::dispatchMessage
Summary: Occasional unreproducible crashes in MessageReceiverMap::dispatchMessage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-09-18 00:04 PDT by Tim Horton
Modified: 2014-09-18 09:26 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.67 KB, patch)
2014-09-18 00:05 PDT, Tim Horton 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-09-18 00:04:49 PDT 
Occasional unreproducible crashes in MessageReceiverMap::dispatchMessage
Comment 1 Tim Horton 2014-09-18 00:05:16 PDT 
Created attachment 238291 [details]
Patch
Comment 2 Tim Horton 2014-09-18 00:08:15 PDT 
Step 2: Make a API test, if possible. Prerequisites include getting TestWebKitAPI a Modern API bundle and ... causing the issue to reproduce at all. Going to try this now, but I want to keep it separate from the fix for mergability's sake (most likely going to change bundle loading code).

Step 3: Fix a few less obviously bad but still confusing cases of message receivers not being removed before the object is destroyed.

Step 4: Add some assertions that catch this and the other cases; Anders and I wrote some nice assertions today that catch all of these things.
Comment 3 Darin Adler 2014-09-18 08:40:06 PDT 
<rdar://problem/17758325>
Comment 4 Tim Horton 2014-09-18 09:26:49 PDT 
http://trac.webkit.org/changeset/173722