RESOLVED FIXED Bug 136901
Change CallFrame::lexicalGlobalObject() to use Callee instead of JSScope 
https://bugs.webkit.org/show_bug.cgi?id=136901
Summary Change CallFrame::lexicalGlobalObject() to use Callee instead of JSScope
Michael Saboff
Reported 2014-09-17 17:19:58 PDT
Change the implementation of CallFrame::lexicalGlobalObject() to use the Callee in preparation for removing JSScope from the CallFrame.
Attachments
Patch (1.25 KB, patch)
2014-09-17 17:33 PDT, Michael Saboff 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 (624.02 KB, application/zip)
2014-09-17 19:04 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion (671.05 KB, application/zip)
2014-09-17 19:54 PDT, Build Bot 		no flags
Details
Patch (1.24 KB, patch)
2014-10-22 14:16 PDT, Michael Saboff 		mark.lam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2014-09-17 17:33:02 PDT
Created attachment 238273 [details] Patch
Build Bot
Comment 2 2014-09-17 19:04:05 PDT
Comment on attachment 238273 [details] Patch Attachment 238273 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5467849288056832 New failing tests: http/tests/security/frameNavigation/context-for-location-assign.html http/tests/security/cookies/document-open.html http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml http/tests/xmlhttprequest/request-from-popup.html http/tests/security/aboutBlank/security-context-write.html http/tests/security/aboutBlank/security-context-window-open.html traversal/node-iterator-prototype.html http/tests/security/aboutBlank/security-context-writeln.html http/tests/security/aboutBlank/security-context.html http/tests/security/aboutBlank/security-context-with-base-tag.html http/tests/security/aboutBlank/security-context-grandchildren-lexical.html fast/frames/sandboxed-iframe-navigation-parent.html http/tests/security/aboutBlank/security-context-grandchildren.html http/tests/security/aboutBlank/security-context-grandchildren-alias.html http/tests/security/calling-versus-current.html http/tests/misc/iframe-domain-test.html http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
Build Bot
Comment 3 2014-09-17 19:04:09 PDT
Created attachment 238281 [details] Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Build Bot
Comment 4 2014-09-17 19:54:30 PDT
Comment on attachment 238273 [details] Patch Attachment 238273 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4634712605720576 New failing tests: http/tests/security/frameNavigation/context-for-location-assign.html http/tests/security/cookies/document-open.html http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml http/tests/security/aboutBlank/security-context-window-open.html http/tests/security/aboutBlank/security-context-write.html traversal/node-iterator-prototype.html http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html http/tests/security/aboutBlank/security-context-writeln.html http/tests/navigation/new-window-redirect-history.html http/tests/security/aboutBlank/security-context-with-base-tag.html http/tests/security/aboutBlank/security-context-grandchildren-lexical.html http/tests/misc/window-open-then-write.html http/tests/xmlhttprequest/request-from-popup.html http/tests/security/aboutBlank/security-context-grandchildren.html http/tests/security/aboutBlank/security-context-grandchildren-alias.html http/tests/security/calling-versus-current.html http/tests/misc/iframe-domain-test.html http/tests/security/aboutBlank/security-context.html fast/dom/Window/window-postmessage-clone-frames.html http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html fast/frames/sandboxed-iframe-navigation-parent.html
Build Bot
Comment 5 2014-09-17 19:54:33 PDT
Created attachment 238282 [details] Archive of layout-test-results from webkit-ews-08 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Michael Saboff
Comment 6 2014-10-22 14:16:18 PDT
Created attachment 240296 [details] Patch Patch ready with the dependent patches closed.
Mark Lam
Comment 7 2014-10-22 14:43:17 PDT
Comment on attachment 240296 [details] Patch r=me
Michael Saboff
Comment 8 2014-10-23 06:15:53 PDT
Committed r175118: <http://trac.webkit.org/changeset/175118>
Note You need to log in before you can comment on or make changes to this bug.