Bug 136898 - [EME][Mac] Support secure proof of key release in the com.apple.fps.2_0 keysystem.
Summary: [EME][Mac] Support secure proof of key release in the com.apple.fps.2_0 keysy...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-09-17 14:57 PDT by Jer Noble
Modified: 2014-12-16 13:27 PST (History)
4 users (show)

See Also:

Attachments
Patch (6.26 KB, patch)
2014-09-17 15:31 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (8.62 KB, patch)
2014-09-17 17:30 PDT, Jer Noble 		eric.carlson: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2014-09-17 14:57:12 PDT 
[EME][Mac] Support secure proof of key release in the com.apple.fps.2_0 keysystem.
Comment 1 Jer Noble 2014-09-17 15:31:01 PDT 
Created attachment 238269 [details]
Patch
Comment 2 WebKit Commit Bot 2014-09-17 15:33:50 PDT 
Attachment 238269 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:169:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Jer Noble 2014-09-17 17:30:06 PDT 
Created attachment 238271 [details]
Patch
Comment 4 Sam Weinig 2014-09-18 17:24:18 PDT 
Can this be tested?
Comment 5 Jer Noble 2014-09-18 18:57:53 PDT 
Not without a FairPlay key server.
Comment 6 Jer Noble 2014-09-18 18:59:47 PDT 
I'm working on a manual test, one that would use a internal key server.
Comment 7 Eric Carlson 2014-09-19 17:20:39 PDT 
Comment on attachment 238271 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238271&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:141
> +    if (!initialized) {

If you use "if (!sessionDirectoryPath.isEmpty())" you can lose the static bool.

> Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:147
> +        sessionDirectoryPath.get().append("AVStreamSession/");

Should use ASCIILiteral.
Comment 8 Jer Noble 2014-09-19 23:55:14 PDT 
Committed r173791: <http://trac.webkit.org/changeset/173791>
Comment 9 Jer Noble 2014-12-16 13:27:56 PST 
<rdar://problem/19269042>