RESOLVED FIXED 136898
[EME][Mac] Support secure proof of key release in the com.apple.fps.2_0 keysystem. 
https://bugs.webkit.org/show_bug.cgi?id=136898
Summary [EME][Mac] Support secure proof of key release in the com.apple.fps.2_0 keysy...
Jer Noble
Reported 2014-09-17 14:57:12 PDT
[EME][Mac] Support secure proof of key release in the com.apple.fps.2_0 keysystem.
Attachments
Patch (6.26 KB, patch)
2014-09-17 15:31 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (8.62 KB, patch)
2014-09-17 17:30 PDT, Jer Noble 		eric.carlson: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2014-09-17 15:31:01 PDT
Created attachment 238269 [details] Patch
WebKit Commit Bot
Comment 2 2014-09-17 15:33:50 PDT
Attachment 238269 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:169: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Jer Noble
Comment 3 2014-09-17 17:30:06 PDT
Created attachment 238271 [details] Patch
Sam Weinig
Comment 4 2014-09-18 17:24:18 PDT
Can this be tested?
Jer Noble
Comment 5 2014-09-18 18:57:53 PDT
Not without a FairPlay key server.
Jer Noble
Comment 6 2014-09-18 18:59:47 PDT
I'm working on a manual test, one that would use a internal key server.
Eric Carlson
Comment 7 2014-09-19 17:20:39 PDT
Comment on attachment 238271 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238271&action=review > Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:141 > + if (!initialized) { If you use "if (!sessionDirectoryPath.isEmpty())" you can lose the static bool. > Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:147 > + sessionDirectoryPath.get().append("AVStreamSession/"); Should use ASCIILiteral.
Jer Noble
Comment 8 2014-09-19 23:55:14 PDT
Committed r173791: <http://trac.webkit.org/changeset/173791>
Jer Noble
Comment 9 2014-12-16 13:27:56 PST
<rdar://problem/19269042>
Note You need to log in before you can comment on or make changes to this bug.