Bug 136893 - Web Inspector: Should be able to attach a debugger to a JSContext before anything is executed
Summary: Web Inspector: Should be able to attach a debugger to a JSContext before anyt...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-09-17 12:26 PDT by Joseph Pecoraro
Modified: 2014-09-23 16:59 PDT (History)
11 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (36.22 KB, patch)
2014-09-18 11:51 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[PATCH] For Bots 1 (39.90 KB, patch)
2014-09-18 16:24 PDT, Joseph Pecoraro 		joepeck: commit-queue-
Details | Formatted Diff | Diff
[PATCH] For Bots 2 (39.93 KB, patch)
2014-09-18 17:51 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix (39.97 KB, patch)
2014-09-22 15:02 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-09-17 12:26:40 PDT 
A shortcoming of JSContext inspection right now is that by the time you attach an Inspector you may have missed something (e.g. some evaluateScript invocations). There should be a way to have a debugger attach to a JSContext before any evaluations happens.
Comment 1 Radar WebKit Bug Importer 2014-09-17 12:27:16 PDT 
<rdar://problem/18369504>
Comment 2 Joseph Pecoraro 2014-09-18 11:51:06 PDT 
Created attachment 238316 [details]
[PATCH] Proposed Fix
Comment 3 WebKit Commit Bot 2014-09-18 11:52:37 PDT 
Attachment 238316 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/Assertions.cpp:399:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WTF/wtf/Assertions.cpp:401:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/JavaScriptCore/runtime/JSGlobalObjectDebuggable.cpp:31:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 3 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 WebKit Commit Bot 2014-09-18 12:48:04 PDT 
Comment on attachment 238316 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 238316

Committed r173731: <http://trac.webkit.org/changeset/173731>
Comment 5 WebKit Commit Bot 2014-09-18 12:48:07 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Csaba Osztrogonác 2014-09-18 14:15:45 PDT 
(In reply to comment #4)
> (From update of attachment 238316 [details])
> Clearing flags on attachment: 238316
> 
> Committed r173731: <http://trac.webkit.org/changeset/173731>

It broke the Apple Windows, GTK and EFL build, please fix them.
Comment 7 Joseph Pecoraro 2014-09-18 15:07:22 PDT 
(In reply to comment #6)
> (In reply to comment #4)
> > (From update of attachment 238316 [details] [details])
> > Clearing flags on attachment: 238316
> > 
> > Committed r173731: <http://trac.webkit.org/changeset/173731>
> 
> It broke the Apple Windows, GTK and EFL build, please fix them.

Rolled out in r173736: <http://trac.webkit.org/changeset/173736>.

Commit-queue beat the EWS bots. I'll address this using EWS to test.
Comment 8 Joseph Pecoraro 2014-09-18 15:07:46 PDT 
Reopening because this was rolled out.
Comment 9 Joseph Pecoraro 2014-09-18 16:24:24 PDT 
Created attachment 238332 [details]
[PATCH] For Bots 1

I will need the Win EWS to give me the new symbol name. This should fix style and EFL.
Comment 10 WebKit Commit Bot 2014-09-18 16:26:59 PDT 
Attachment 238332 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/JSGlobalObjectDebuggable.cpp:31:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 11 Joseph Pecoraro 2014-09-18 17:51:52 PDT 
Created attachment 238341 [details]
[PATCH] For Bots 2

Windows bot failed without the patch. Trying Windows again.
Comment 12 Joseph Pecoraro 2014-09-22 15:02:28 PDT 
Created attachment 238498 [details]
[PATCH] Proposed Fix

This should get things working for windows now.
Comment 13 WebKit Commit Bot 2014-09-23 11:38:32 PDT 
Comment on attachment 238498 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 238498

Committed r173882: <http://trac.webkit.org/changeset/173882>
Comment 14 WebKit Commit Bot 2014-09-23 11:38:37 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 15 Brent Fulgham 2014-09-23 16:28:06 PDT 
The mangled symbol name for 64-bit Windows is wrong, breaking the build. I'll check-in a fix as soon as my local build finishes.
Comment 16 Joseph Pecoraro 2014-09-23 16:40:43 PDT 
(In reply to comment #15)
> The mangled symbol name for 64-bit Windows is wrong, breaking the build. I'll check-in a fix as soon as my local build finishes.

Doh! Thanks.
Comment 17 Brent Fulgham 2014-09-23 16:59:58 PDT 
Build fix for 64-bit Windows committed in r173900 <http://trac.webkit.org/changeset/173900>.