Bug 136893 – Web Inspector: Should be able to attach a debugger to a JSContext before anything is executed

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

A shortcoming of JSContext inspection right now is that by the time you attach an Inspector you may have missed something (e.g. some evaluateScript invocations). There should be a way to have a debugger attach to a JSContext before any evaluations happens.

[Radar WebKit Bug Importer]

<rdar://problem/18369504>

[Joseph Pecoraro]

Created attachment 238316 [details]
[PATCH] Proposed Fix

[WebKit Commit Bot]

Attachment 238316 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/Assertions.cpp:399:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WTF/wtf/Assertions.cpp:401:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/JavaScriptCore/runtime/JSGlobalObjectDebuggable.cpp:31:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 3 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 238316 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 238316

Committed r173731: <http://trac.webkit.org/changeset/173731>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

(In reply to comment #4)
> (From update of attachment 238316 [details])
> Clearing flags on attachment: 238316
> 
> Committed r173731: <http://trac.webkit.org/changeset/173731>

It broke the Apple Windows, GTK and EFL build, please fix them.

[Joseph Pecoraro]

(In reply to comment #6)
> (In reply to comment #4)
> > (From update of attachment 238316 [details] [details])
> > Clearing flags on attachment: 238316
> > 
> > Committed r173731: <http://trac.webkit.org/changeset/173731>
> 
> It broke the Apple Windows, GTK and EFL build, please fix them.

Rolled out in r173736: <http://trac.webkit.org/changeset/173736>.

Commit-queue beat the EWS bots. I'll address this using EWS to test.

[Joseph Pecoraro]

Reopening because this was rolled out.

[Joseph Pecoraro]

Created attachment 238332 [details]
[PATCH] For Bots 1

I will need the Win EWS to give me the new symbol name. This should fix style and EFL.

[WebKit Commit Bot]

Attachment 238332 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/JSGlobalObjectDebuggable.cpp:31:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Joseph Pecoraro]

Created attachment 238341 [details]
[PATCH] For Bots 2

Windows bot failed without the patch. Trying Windows again.

[Joseph Pecoraro]

Created attachment 238498 [details]
[PATCH] Proposed Fix

This should get things working for windows now.

[WebKit Commit Bot]

Comment on attachment 238498 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 238498

Committed r173882: <http://trac.webkit.org/changeset/173882>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Brent Fulgham]

The mangled symbol name for 64-bit Windows is wrong, breaking the build. I'll check-in a fix as soon as my local build finishes.

[Joseph Pecoraro]

(In reply to comment #15)
> The mangled symbol name for 64-bit Windows is wrong, breaking the build. I'll check-in a fix as soon as my local build finishes.

Doh! Thanks.

[Brent Fulgham]

Build fix for 64-bit Windows committed in r173900 <http://trac.webkit.org/changeset/173900>.