Bug 136891 - [GTK] Fix runtime critical warnings when writing to the clipboard after r173687
Summary: [GTK] Fix runtime critical warnings when writing to the clipboard after r173687
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2014-09-17 09:01 PDT by Carlos Garcia Campos
Modified: 2014-09-17 09:13 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.94 KB, patch)
2014-09-17 09:03 PDT, Carlos Garcia Campos 		pnormand: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2014-09-17 09:01:10 PDT 
TEST: bin/TestWebKitAPI/WebKit2Gtk/TestWebViewEditor... (pid=4979)
  /webkit2/WebKitWebView/cut-copy-paste/non-editable:                  
(WebKitWebProcess:4985): GLib-GObject-CRITICAL **: g_closure_ref: assertion 'closure != NULL' failed
OK
  /webkit2/WebKitWebView/cut-copy-paste/editable:                      
(WebKitWebProcess:4985): GLib-GObject-CRITICAL **: g_closure_ref: assertion 'closure != NULL' failed
OK
  /webkit2/WebKitWebView/select-all/non-editable:                      
(WebKitWebProcess:4985): GLib-GObject-CRITICAL **: g_closure_ref: assertion 'closure != NULL' failed

(WebKitWebProcess:4985): GLib-GObject-CRITICAL **: g_closure_ref: assertion 'closure != NULL' failed
OK
  /webkit2/WebKitWebView/select-all/editable:                          
(WebKitWebProcess:4985): GLib-GObject-CRITICAL **: g_closure_ref: assertion 'closure != NULL' failed

(WebKitWebProcess:4985): GLib-GObject-CRITICAL **: g_closure_ref: assertion 'closure != NULL' failed
OK
PASS: bin/TestWebKitAPI/WebKit2Gtk/TestWebViewEditor
Comment 1 Carlos Garcia Campos 2014-09-17 09:03:52 PDT 
Created attachment 238254 [details]
Patch
Comment 2 Philippe Normand 2014-09-17 09:07:49 PDT 
Comment on attachment 238254 [details]
Patch

LGTM!
Comment 3 Carlos Garcia Campos 2014-09-17 09:13:07 PDT 
Committed r173692: <http://trac.webkit.org/changeset/173692>