Bug 136887 – [GTK] Assertion in RenderLayerCompositor

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Philippe Normand]

ASSERTION FAILED: !m_flushingLayers
../../Source/WebCore/rendering/RenderLayerCompositor.cpp(410) : void WebCore::RenderLayerCompositor::scheduleLayerFlush(bool)
[Thread 0x7fff5ffff700 (LWP 32413) exited]
1   0x7fffed257474 /fast/WebKit/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(WTFCrash+0x1e) [0x7fffed257474]
2   0x7ffff393a600 /fast/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore21RenderLayerCompositor18scheduleLayerFlushEb+0x44) [0x7ffff393a600]
3   0x7ffff39385d1 /fast/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore18RenderLayerBacking19notifyFlushRequiredEPKNS_13GraphicsLayerE+0x5d) [0x7ffff39385d1]
4   0x7ffff3dd622a /fast/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore26GraphicsLayerTextureMapper12notifyChangeENS0_10ChangeMaskE+0x62) [0x7ffff3dd622a]
5   0x7ffff3dd64b0 /fast/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore26GraphicsLayerTextureMapper21setNeedsDisplayInRectERKNS_9FloatRectENS_13GraphicsLayer17ShouldClipToLayerE+0x64) $
0x7ffff3dd64b0]
6   0x7ffff3935eba /fast/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore18RenderLayerBacking28setContentsNeedDisplayInRectERKNS_10LayoutRectENS_13GraphicsLayer17ShouldClipToLayerE+0x238$
 [0x7ffff3935eba]
7   0x7ffff391d370 /fast/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore11RenderLayer28setBackingNeedsRepaintInRectERKNS_10LayoutRectENS_13GraphicsLayer17ShouldClipToLayerE+0x116) [0x7f$
ff391d370]
8   0x7ffff398c54d /fast/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZNK7WebCore12RenderObject21repaintUsingContainerEPKNS_22RenderLayerModelObjectERKNS_10LayoutRectEb+0x33f) [0x7ffff398c54d]
9   0x7ffff398c6d7 /fast/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZNK7WebCore12RenderObject16repaintRectangleERKNS_10LayoutRectEb+0xd7) [0x7ffff398c6d7]
10  0x7ffff3860fb5 /fast/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore9RenderBox25repaintLayerRectsForImageEPKvPKNS_9FillLayerEb+0x6ed) [0x7ffff3860fb5]
11  0x7ffff38607c6 /fast/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore9RenderBox12imageChangedEPKvPKNS_7IntRectE+0x1d4) [0x7ffff38607c6]
12  0x7ffff38f2448 /fast/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore11RenderImage12imageChangedEPKvPKNS_7IntRectE+0xa8) [0x7ffff38f2448]
13  0x7ffff39f0d8e /fast/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore11RenderVideo12imageChangedEPKvPKNS_7IntRectE+0x2c) [0x7ffff39f0d8e]
14  0x7ffff399048f /fast/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore12RenderObject12imageChangedEPNS_11CachedImageEPKNS_7IntRectE+0x35) [0x7ffff399048f]
15  0x7ffff38aa5da /fast/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore13RenderElement31newImageAnimationFrameAvailableERNS_11CachedImageE+0xb6) [0x7ffff38aa5da]
16  0x7ffff34b778e /fast/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore11CachedImage17animationAdvancedEPKNS_5ImageE+0x94) [0x7ffff34b778e]
17  0x7ffff36832a4 /fast/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore11BitmapImage24internalAdvanceAnimationEb+0x13c) [0x7ffff36832a4]
18  0x7ffff3682d05 /fast/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore11BitmapImage14startAnimationENS_5Image16CatchUpAnimationE+0x491) [0x7ffff3682d05]
19  0x7ffff3d43d4b /fast/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore11BitmapImage4drawEPNS_15GraphicsContextERKNS_9FloatRectES5_NS_10ColorSpaceENS_17CompositeOperatorENS_9BlendModeE$
S_27ImageOrientationDescriptionE+0xe3) [0x7ffff3d43d4b]
20  0x7ffff36ddf19 /fast/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore5Image9drawTiledEPNS_15GraphicsContextERKNS_9FloatRectERKNS_10FloatPointERKNS_9FloatSizeENS_10ColorSpaceENS_17Com$
ositeOperatorENS_9BlendModeE+0x695) [0x7ffff36ddf19]
21  0x7ffff36c9620 /fast/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore15GraphicsContext14drawTiledImageEPNS_5ImageENS_10ColorSpaceERKNS_9FloatRectERKNS_10FloatPointERKNS_9FloatSizeERK$
S_20ImagePaintingOptionsE+0xb4) [0x7ffff36c9620]
22  0x7ffff387dca3 /fast/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore20RenderBoxModelObject22paintFillLayerExtendedERKNS_9PaintInfoERKNS_5ColorEPKNS_9FillLayerERKNS_10LayoutRectENS_2$
BackgroundBleedAvoidanceEPNS_13InlineFlowBoxERKNS_10LayoutSizeENS_17CompositeOperatorEPNS_13RenderElementENS_24BaseBackgroundColorUsageE+0x1be5) [0x7ffff387dca3]
23  0x7ffff386056a /fast/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore9RenderBox14paintFillLayerERKNS_9PaintInfoERKNS_5ColorEPKNS_9FillLayerERKNS_10LayoutRectENS_24BackgroundBleedAvoi$
anceENS_17CompositeOperatorEPNS_13RenderElementENS_24BaseBackgroundColorUsageE+0x62) [0x7ffff386056a]
24  0x7ffff3860497 /fast/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore9RenderBox15paintFillLayersERKNS_9PaintInfoERKNS_5ColorEPKNS_9FillLayerERKNS_10LayoutRectENS_24BackgroundBleedAvo$
danceENS_17CompositeOperatorEPNS_13RenderElementE+0x2b5) [0x7ffff3860497]
25  0x7ffff385f21b /fast/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore9RenderBox15paintBackgroundERKNS_9PaintInfoERKNS_10LayoutRectENS_24BackgroundBleedAvoidanceE+0x11b) [0x7ffff385f2$
b]
26  0x7ffff385ef40 /fast/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore9RenderBox19paintBoxDecorationsERNS_9PaintInfoERKNS_11LayoutPointE+0x3ae) [0x7ffff385ef40]
27  0x7ffff399a219 /fast/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore14RenderReplaced5paintERNS_9PaintInfoERKNS_11LayoutPointE+0xf7) [0x7ffff399a219]
28  0x7ffff38f401b /fast/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore11RenderImage5paintERNS_9PaintInfoERKNS_11LayoutPointE+0x2b) [0x7ffff38f401b]
29  0x7ffff3915590 /fast/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore11RenderLayer36paintForegroundForFragmentsWithPhaseENS_10PaintPhaseERKN3WTF6VectorINS_13LayerFragmentELm1ENS2_15C$
ashOnOverflowEEEPNS_15GraphicsContextERKNS0_17LayerPaintingInfoEjPNS_12RenderObjectE+0x216) [0x7ffff3915590]
30  0x7ffff3915249 /fast/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore11RenderLayer27paintForegroundForFragmentsERKN3WTF6VectorINS_13LayerFragmentELm1ENS1_15CrashOnOverflowEEEPNS_15Gr$
phicsContextES9_RKNS_10LayoutRectEbRKNS0_17LayerPaintingInfoEjPNS_12RenderObjectEb+0x25b) [0x7ffff3915249]
31  0x7ffff391379d /fast/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore11RenderLayer18paintLayerContentsEPNS_15GraphicsContextERKNS0_17LayerPaintingInfoEj+0x6a1) [0x7ffff391379d]

Trace:
(gdb) bt
#0  0x00007fffed257479 in WTFCrash () at ../../Source/WTF/wtf/Assertions.cpp:329
#1  0x00007ffff393a600 in WebCore::RenderLayerCompositor::scheduleLayerFlush (this=0xa1ac00, canThrottle=false) at ../../Source/WebCore/rendering/RenderLayerCompositor.cpp:410
#2  0x00007ffff39385d1 in WebCore::RenderLayerBacking::notifyFlushRequired (this=0x13b3300, layer=0x13b3410) at ../../Source/WebCore/rendering/RenderLayerBacking.cpp:2455
#3  0x00007ffff3dd622a in WebCore::GraphicsLayerTextureMapper::notifyChange (this=0x13b3410, changeMask=WebCore::GraphicsLayerTextureMapper::DisplayChange)
    at ../../Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:66
#4  0x00007ffff3dd64b0 in WebCore::GraphicsLayerTextureMapper::setNeedsDisplayInRect (this=0x13b3410, rect=...) at ../../Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:117
#5  0x00007ffff3935eba in WebCore::RenderLayerBacking::setContentsNeedDisplayInRect (this=0x13b3300, r=..., shouldClip=WebCore::GraphicsLayer::ClipToLayer)
    at ../../Source/WebCore/rendering/RenderLayerBacking.cpp:2067
#6  0x00007ffff391d370 in WebCore::RenderLayer::setBackingNeedsRepaintInRect (this=0x81e830, r=..., shouldClip=WebCore::GraphicsLayer::ClipToLayer) at ../../Source/WebCore/rendering/RenderLayer.cpp:6210
#7  0x00007ffff398c54d in WebCore::RenderObject::repaintUsingContainer (this=0x981490, repaintContainer=0x981490, r=..., shouldClipToLayer=true) at ../../Source/WebCore/rendering/RenderObject.cpp:1293
#8  0x00007ffff398c6d7 in WebCore::RenderObject::repaintRectangle (this=0x981490, r=..., shouldClipToLayer=true) at ../../Source/WebCore/rendering/RenderObject.cpp:1329
#9  0x00007ffff3860fb5 in WebCore::RenderBox::repaintLayerRectsForImage (this=0x981490, image=0xb56de0, layers=0xfb0658, drawingBackground=true) at ../../Source/WebCore/rendering/RenderBox.cpp:1688
#10 0x00007ffff38607c6 in WebCore::RenderBox::imageChanged (this=0x981490, image=0xb56de0) at ../../Source/WebCore/rendering/RenderBox.cpp:1621
#11 0x00007ffff38f2448 in WebCore::RenderImage::imageChanged (this=0x981490, newImage=0xb56de0, rect=0x0) at ../../Source/WebCore/rendering/RenderImage.cpp:240
#12 0x00007ffff39f0d8e in WebCore::RenderVideo::imageChanged (this=0x981490, newImage=0xb56de0, rect=0x0) at ../../Source/WebCore/rendering/RenderVideo.cpp:131
#13 0x00007ffff399048f in WebCore::RenderObject::imageChanged (this=0x981490, image=0xb56de0, rect=0x0) at ../../Source/WebCore/rendering/RenderObject.cpp:2417
#14 0x00007ffff38aa5da in WebCore::RenderElement::newImageAnimationFrameAvailable (this=0x981490, image=...) at ../../Source/WebCore/rendering/RenderElement.cpp:1319
#15 0x00007ffff34b778e in WebCore::CachedImage::animationAdvanced (this=0xb56de0, image=0x1882530) at ../../Source/WebCore/loader/cache/CachedImage.cpp:488
#16 0x00007ffff36832a4 in WebCore::BitmapImage::internalAdvanceAnimation (this=0x1882530, skippingFrames=false) at ../../Source/WebCore/platform/graphics/BitmapImage.cpp:671
#17 0x00007ffff3682d05 in WebCore::BitmapImage::startAnimation (this=0x1882530, catchUpIfNecessary=WebCore::Image::CatchUp) at ../../Source/WebCore/platform/graphics/BitmapImage.cpp:555
#18 0x00007ffff3d43d4b in WebCore::BitmapImage::draw (this=0x1882530, context=0x18b87f0, dst=..., src=..., styleColorSpace=WebCore::ColorSpaceDeviceRGB, op=WebCore::CompositeSourceOver, 
    blendMode=WebCore::BlendModeNormal, description=...) at ../../Source/WebCore/platform/graphics/cairo/BitmapImageCairo.cpp:71
#19 0x00007ffff36ddf19 in WebCore::Image::drawTiled (this=0x1882530, ctxt=0x18b87f0, destRect=..., srcPoint=..., scaledTileSize=..., styleColorSpace=WebCore::ColorSpaceDeviceRGB, 
    op=WebCore::CompositeSourceOver, blendMode=WebCore::BlendModeNormal) at ../../Source/WebCore/platform/graphics/Image.cpp:132
#20 0x00007ffff36c9620 in WebCore::GraphicsContext::drawTiledImage (this=0x18b87f0, image=0x1882530, colorSpace=WebCore::ColorSpaceDeviceRGB, destination=..., source=..., tileSize=..., 
    imagePaintingOptions=...) at ../../Source/WebCore/platform/graphics/GraphicsContext.cpp:600
#21 0x00007ffff387dca3 in WebCore::RenderBoxModelObject::paintFillLayerExtended (this=0x981490, paintInfo=..., color=..., bgLayer=0xfb0658, rect=..., bleedAvoidance=WebCore::BackgroundBleedNone, box=
    0x0, boxSize=..., op=WebCore::CompositeSourceOver, backgroundObject=0x0, baseBgColorUsage=WebCore::BaseBackgroundColorUse) at ../../Source/WebCore/rendering/RenderBoxModelObject.cpp:848
#22 0x00007ffff386056a in WebCore::RenderBox::paintFillLayer (this=0x981490, paintInfo=..., c=..., fillLayer=0xfb0658, rect=..., bleedAvoidance=WebCore::BackgroundBleedNone, 
    op=WebCore::CompositeSourceOver, backgroundObject=0x0, baseBgColorUsage=WebCore::BaseBackgroundColorUse) at ../../Source/WebCore/rendering/RenderBox.cpp:1589
#23 0x00007ffff3860497 in WebCore::RenderBox::paintFillLayers (this=0x981490, paintInfo=..., c=..., fillLayer=0xfb0658, rect=..., bleedAvoidance=WebCore::BackgroundBleedNone, 
    op=WebCore::CompositeSourceOver, backgroundObject=0x0) at ../../Source/WebCore/rendering/RenderBox.cpp:1580
#24 0x00007ffff385f21b in WebCore::RenderBox::paintBackground (this=0x981490, paintInfo=..., paintRect=..., bleedAvoidance=WebCore::BackgroundBleedNone)
    at ../../Source/WebCore/rendering/RenderBox.cpp:1311
#25 0x00007ffff385ef40 in WebCore::RenderBox::paintBoxDecorations (this=0x981490, paintInfo=..., paintOffset=...) at ../../Source/WebCore/rendering/RenderBox.cpp:1286
#26 0x00007ffff399a219 in WebCore::RenderReplaced::paint (this=0x981490, paintInfo=..., paintOffset=...) at ../../Source/WebCore/rendering/RenderReplaced.cpp:141
#27 0x00007ffff38f401b in WebCore::RenderImage::paint (this=0x981490, paintInfo=..., paintOffset=...) at ../../Source/WebCore/rendering/RenderImage.cpp:499
#28 0x00007ffff3915590 in WebCore::RenderLayer::paintForegroundForFragmentsWithPhase (this=0x81e830, phase=WebCore::PaintPhaseForeground, layerFragments=WTF::Vector of length 1, capacity 1 = {...}, 
    context=0x18b87f0, localPaintingInfo=..., paintBehavior=0, subtreePaintRootForRenderer=0x0) at ../../Source/WebCore/rendering/RenderLayer.cpp:4581
#29 0x00007ffff3915249 in WebCore::RenderLayer::paintForegroundForFragments (this=0x81e830, layerFragments=WTF::Vector of length 1, capacity 1 = {...}, context=0x18b87f0, 
    transparencyLayerContext=0x18b87f0, transparencyPaintDirtyRect=..., haveTransparency=false, localPaintingInfo=..., paintBehavior=0, subtreePaintRootForRenderer=0x0, selectionOnly=false)
    at ../../Source/WebCore/rendering/RenderLayer.cpp:4545
#30 0x00007ffff391379d in WebCore::RenderLayer::paintLayerContents (this=0x81e830, context=0x18b87f0, paintingInfo=..., paintFlags=224) at ../../Source/WebCore/rendering/RenderLayer.cpp:4170
#31 0x00007ffff39365d2 in WebCore::RenderLayerBacking::paintIntoLayer (this=0x13b3300, graphicsLayer=0x13b3410, context=0x18b87f0, paintDirtyRect=..., paintBehavior=0, paintingPhase=7)
    at ../../Source/WebCore/rendering/RenderLayerBacking.cpp:2143
#32 0x00007ffff3936a49 in WebCore::RenderLayerBacking::paintContents (this=0x13b3300, graphicsLayer=0x13b3410, context=..., paintingPhase=7, clip=...)
    at ../../Source/WebCore/rendering/RenderLayerBacking.cpp:2194
#33 0x00007ffff36d19b1 in WebCore::GraphicsLayer::paintGraphicsLayerContents (this=0x13b3410, context=..., clip=...) at ../../Source/WebCore/platform/graphics/GraphicsLayer.cpp:351
#34 0x00007ffff3720ed5 in WebCore::BitmapTexture::updateContents (this=0x9a5b30, textureMapper=0x13b0960, sourceLayer=0x13b3410, targetRect=..., offset=..., 
    updateContentsFlag=WebCore::BitmapTexture::UpdateCanModifyOriginalImageData) at ../../Source/WebCore/platform/graphics/texmap/TextureMapper.cpp:161
#35 0x00007ffff372b3fb in WebCore::TextureMapperTile::updateContents (this=0x98dc60, textureMapper=0x13b0960, sourceLayer=0x13b3410, dirtyRect=..., 
    updateContentsFlag=WebCore::BitmapTexture::UpdateCanModifyOriginalImageData) at ../../Source/WebCore/platform/graphics/texmap/TextureMapperTile.cpp:69
#36 0x00007ffff372c33c in WebCore::TextureMapperTiledBackingStore::updateContents (this=0xa6f970, textureMapper=0x13b0960, sourceLayer=0x13b3410, totalSize=..., dirtyRect=..., 
    updateContentsFlag=WebCore::BitmapTexture::UpdateCanModifyOriginalImageData) at ../../Source/WebCore/platform/graphics/texmap/TextureMapperTiledBackingStore.cpp:147
#37 0x00007ffff3dd7f89 in WebCore::GraphicsLayerTextureMapper::updateBackingStoreIfNeeded (this=0x13b3410) at ../../Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:613
#38 0x00007ffff3dd70e8 in WebCore::GraphicsLayerTextureMapper::flushCompositingStateForThisLayerOnly (this=0x13b3410) at ../../Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:439
#39 0x00007ffff3dd7cec in WebCore::GraphicsLayerTextureMapper::flushCompositingState (this=0x13b3410, rect=...) at ../../Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:583
#40 0x00007ffff3dd7da6 in WebCore::GraphicsLayerTextureMapper::flushCompositingState (this=0x98d7a0, rect=...) at ../../Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:590
#41 0x00007ffff3dd7da6 in WebCore::GraphicsLayerTextureMapper::flushCompositingState (this=0xfed5f0, rect=...) at ../../Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:590
#42 0x00007ffff3dd7da6 in WebCore::GraphicsLayerTextureMapper::flushCompositingState (this=0xff3f00, rect=...) at ../../Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:590
#43 0x00007ffff3dd7da6 in WebCore::GraphicsLayerTextureMapper::flushCompositingState (this=0x9a0090, rect=...) at ../../Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:590
#44 0x00007ffff3dd7da6 in WebCore::GraphicsLayerTextureMapper::flushCompositingState (this=0xfe8480, rect=...) at ../../Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:590
#45 0x00007ffff393a8b7 in WebCore::RenderLayerCompositor::flushPendingLayerChanges (this=0xa1ac00, isFlushRoot=true) at ../../Source/WebCore/rendering/RenderLayerCompositor.cpp:466
#46 0x00007ffff3579987 in WebCore::FrameView::flushCompositingStateForThisFrame (this=0x93ba80, rootFrameForFlush=0x988000) at ../../Source/WebCore/page/FrameView.cpp:897
#47 0x00007ffff357a15b in WebCore::FrameView::flushCompositingStateIncludingSubframes (this=0x93ba80) at ../../Source/WebCore/page/FrameView.cpp:1049
#48 0x00007ffff2a0154c in WebKit::LayerTreeHostGtk::flushPendingLayerChanges (this=0xa36ef0) at ../../Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:297
#49 0x00007ffff2a017b5 in WebKit::LayerTreeHostGtk::flushAndRenderLayers (this=0xa36ef0) at ../../Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:339
#50 0x00007ffff2a01260 in WebKit::LayerTreeHostGtk::layerFlushTimerFired (this=0xa36ef0) at ../../Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:278
#51 0x00007ffff2a0319f in std::_Mem_fn<void (WebKit::LayerTreeHostGtk::*)()>::operator()<, void>(WebKit::LayerTreeHostGtk*) const (this=0x18ea9d0, __object=0xa36ef0)
    at /usr/include/c++/4.9/functional:569
#52 0x00007ffff2a030ba in std::_Bind<std::_Mem_fn<void (WebKit::LayerTreeHostGtk::*)()> (WebKit::LayerTreeHostGtk*)>::__call<void, , 0ul>(std::tuple<>&&, std::_Index_tuple<0ul>) (this=0x18ea9d0, 
    __args=<unknown type in /fast/WebKit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37, CU 0x6439c54, DIE 0x64a7653>) at /usr/include/c++/4.9/functional:1264
#53 0x00007ffff2a02c68 in std::_Bind<std::_Mem_fn<void (WebKit::LayerTreeHostGtk::*)()> (WebKit::LayerTreeHostGtk*)>::operator()<, void>() (this=0x18ea9d0) at /usr/include/c++/4.9/functional:1323
#54 0x00007ffff2a029c3 in std::_Function_handler<void (), std::_Bind<std::_Mem_fn<void (WebKit::LayerTreeHostGtk::*)()> (WebKit::LayerTreeHostGtk*)> >::_M_invoke(std::_Any_data const&) (__functor=...)
    at /usr/include/c++/4.9/functional:2039
#55 0x00007ffff261e9fc in std::function<void ()>::operator()() const (this=0xa36f90) at /usr/include/c++/4.9/functional:2439
#56 0x00007fffed29d325 in WTF::GMainLoopSource::voidCallback (this=0xa36f78) at ../../Source/WTF/wtf/gobject/GMainLoopSource.cpp:195
#57 0x00007fffed29d696 in WTF::GMainLoopSource::voidSourceCallback (source=0xa36f78) at ../../Source/WTF/wtf/gobject/GMainLoopSource.cpp:255
#58 0x00007fffe9fb3c56 in g_main_dispatch (context=0x6530e0) at gmain.c:3065
#59 g_main_context_dispatch (context=context@entry=0x6530e0) at gmain.c:3641
#60 0x00007fffe9fb3fa8 in g_main_context_iterate (context=0x6530e0, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at gmain.c:3712
#61 0x00007fffe9fb43aa in g_main_loop_run (loop=0xc065a0) at gmain.c:3906
#62 0x00007ffff44a9ec6 in WTF::RunLoop::run () at ../../Source/WTF/wtf/gtk/RunLoopGtk.cpp:59
#63 0x00007ffff2a0ad24 in WebKit::ChildProcessMain<WebKit::WebProcess, WebKit::WebProcessMain> (argc=2, argv=0x7fffffffd768) at ../../Source/WebKit2/Shared/unix/ChildProcessMain.h:61
#64 0x00007ffff2a0ab90 in WebKit::WebProcessMainUnix (argc=2, argv=0x7fffffffd768) at ../../Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp:73
#65 0x00000000004007f6 in main (argc=2, argv=0x7fffffffd768) at ../../Source/WebKit2/WebProcess/EntryPoint/unix/WebProcessMain.cpp:32

[Gwang Yoon Hwang]

Created attachment 244150 [details]
Patch

[Zan Dobersek]

Comment on attachment 244150 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244150&action=review

> Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:528
> +static GraphicsLayerTextureMapper& toGraphicsLayerTextureMapper(GraphicsLayer* layer)
> +{
> +    return downcast<GraphicsLayerTextureMapper>(*layer);
> +}

Can we avoid this? I know downcast<> gets repetitive in the method below, but there's no gain in this function either.

> Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:306
> +    bool didFlush = m_webPage->corePage()->mainFrame().view()->flushCompositingStateIncludingSubframes();
> +
> +    if (!didFlush)
> +        return false;

If it doesn't diminish readability for your taste, you could avoid using the didFlush variable altogether.

[Gwang Yoon Hwang]

Created attachment 244151 [details]
Patch

[Gwang Yoon Hwang]

(In reply to comment #2)
> Comment on attachment 244150 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=244150&action=review
> 
> > Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:528
> > +static GraphicsLayerTextureMapper& toGraphicsLayerTextureMapper(GraphicsLayer* layer)
> > +{
> > +    return downcast<GraphicsLayerTextureMapper>(*layer);
> > +}
> 
> Can we avoid this? I know downcast<> gets repetitive in the method below,
> but there's no gain in this function either.
> 

Yep, that's quite interesting that I added 148 characters to reduce 24 characters.
I removed the static function.

> > Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:306
> > +    bool didFlush = m_webPage->corePage()->mainFrame().view()->flushCompositingStateIncludingSubframes();
> > +
> > +    if (!didFlush)
> > +        return false;
> 
> If it doesn't diminish readability for your taste, you could avoid using the
> didFlush variable altogether.

I added it because the return value of flushCompositingStateIncludingSubframes is ambiguous. But I think it is okay to avoid using temporal variable.

[WebKit Commit Bot]

Comment on attachment 244151 [details]
Patch

Rejecting attachment 244151 [details] from review queue.

[e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

[Zan Dobersek]

Comment on attachment 244151 [details]
Patch

cq restarted recently, maybe it works this time ...

[WebKit Commit Bot]

Comment on attachment 244151 [details]
Patch

Rejecting attachment 244151 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 244151, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
raphicsLayerTextureMapper.cpp.rej
patching file Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.h
Hunk #1 FAILED at 86.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.h.rej
patching file Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'\u017dan Dober\u0161ek']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/5179226126811136

[Gwang Yoon Hwang]

Created attachment 244250 [details]
Patch

[Gwang Yoon Hwang]

Created attachment 244251 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 244251 [details]
Patch

Clearing flags on attachment: 244251

Committed r178111: <http://trac.webkit.org/changeset/178111>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.