Bug 136884 – Remove unused methods from MediaPlayerClient

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Carlos Garcia Campos]

It seems that some of the methods that introduce dependencies on WebCore types are actually unused.

[Carlos Garcia Campos]

Created attachment 238247 [details]
Patch

[Eric Carlson]

Comment on attachment 238247 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238247&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:5664
>  IntRect HTMLMediaElement::mediaPlayerWindowClipRect()
>  {
> -    return mediaPlayerOwningDocument()->view()->windowClipRect();
> +    return document().view()->windowClipRect();
>  }

It looks like this can be removed from here and MediaPlayerClient, it isn't called by MediaPlayer.

[Carlos Garcia Campos]

Committed r173719: <http://trac.webkit.org/changeset/173719>

[Carlos Garcia Campos]

(In reply to comment #2)
> (From update of attachment 238247 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=238247&action=review
> 
> > Source/WebCore/html/HTMLMediaElement.cpp:5664
> >  IntRect HTMLMediaElement::mediaPlayerWindowClipRect()
> >  {
> > -    return mediaPlayerOwningDocument()->view()->windowClipRect();
> > +    return document().view()->windowClipRect();
> >  }
> 
> It looks like this can be removed from here and MediaPlayerClient, it isn't called by MediaPlayer.

Right, removed it as well. Thanks for the review.