Bug 136880 - Add unprefixed flexbox display values and property names/values
Summary: Add unprefixed flexbox display values and property names/values
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-09-16 19:23 PDT by Dean Jackson
Modified: 2014-09-17 15:07 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.68 KB, patch)
2014-09-16 19:34 PDT, Dean Jackson
benjamin: review+
dino: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2014-09-16 19:23:22 PDT
Add unprefixed flexbox display values and property names/values
Comment 1 Radar WebKit Bug Importer 2014-09-16 19:23:54 PDT
<rdar://problem/18361137>
Comment 2 Dean Jackson 2014-09-16 19:34:09 PDT
Created attachment 238234 [details]
Patch
Comment 3 Joseph Pecoraro 2014-09-17 11:49:27 PDT
Comment on attachment 238234 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238234&action=review

> Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js:365
> +        "flex", "-webkit-flex", "inline-flex", "-webkit-inline-flex", "-webkit-grid", "-webkit-inline-grid"

You can remove the prefixed versions.

> Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js:675
> +    "align-content": [
> +        "flex-start", "flex-end", "center", "space-between", "space-around", "stretch"
> +    ],
>      "-webkit-align-content": [
>          "flex-start", "flex-end", "center", "space-between", "space-around", "stretch"
>      ],

All of these are identical! So the duplication is unnecessary. You should just remove the "-webkit-" prefix versions. Things will just work for prefixed and unprefixed autocompletion (see WebInspector.CSSKeywordCompletions.forProperty).
Comment 4 Dean Jackson 2014-09-17 15:07:02 PDT
Committed r173705: <http://trac.webkit.org/changeset/173705>