Bug 136879 – Fix an issue that caused video playback to not always use high resolution streams

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Fix an issue that caused video playback to not always use high resolution streams

[Simon Fraser (smfr)]

Created attachment 238235 [details]
Patch

[Jeremy Jones]

Comment on attachment 238235 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238235&action=review

> Source/WebCore/WebCore.exp.in:3441
> -__ZN7WebCore32WebVideoFullscreenInterfaceAVKit15setupFullscreenER7CALayerNS_7IntRectEP6UIView
> +__ZN7WebCore32WebVideoFullscreenInterfaceAVKit15setupFullscreenER7CALayerNS_7IntRectEfP6UIView

This can be done without changing the WebVideoFullscreenInterfaceAVKit interface.

> Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm:128
> -    _interface->setupFullscreen(*_videoFullscreenLayer.get(), _mediaElement->clientRect(), view);
> +    _interface->setupFullscreen(*_videoFullscreenLayer.get(), _mediaElement->clientRect(), 1, view);

Don't need this if the change is isolated to the IPC interface.

> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.h:95
> -    virtual void setupFullscreen(PlatformLayer&, WebCore::IntRect initialRect, UIView *);
> +    virtual void setupFullscreen(PlatformLayer&, WebCore::IntRect initialRect, float hostingDeviceScaleFactor, UIView *);

Ditto.

> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:737
> -void WebVideoFullscreenInterfaceAVKit::setupFullscreen(PlatformLayer& videoLayer, WebCore::IntRect initialRect, UIView* parentView)
> +void WebVideoFullscreenInterfaceAVKit::setupFullscreen(PlatformLayer& videoLayer, WebCore::IntRect initialRect, float hostingDeviceScaleFactor, UIView* parentView)

Ditto.

> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:764
> +
> +        if (hostingDeviceScaleFactor != 1) {
> +            // Invert the scale transform added in the WebProcess to fix <rdar://problem/18316542>.
> +            float inverseScale = 1 / hostingDeviceScaleFactor;
> +            [m_videoLayer setTransform:CATransform3DMakeScale(inverseScale, inverseScale, 1)];
> +        }

This can be put into WebVideoFullscreenManagerProxy::setupFullscreenWithID, just before it calls setupFullsdcreen.

> Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.mm:80
> -    setupFullscreen(*m_layerHost.get(), initialRect, parentView);
> +    setupFullscreen(*m_layerHost.get(), initialRect, hostingDeviceScaleFactor, parentView);

Apply the transform here on m_layerHost instead of passing it to setupFullscreen.

[Simon Fraser (smfr)]

Created attachment 238260 [details]
Patch

[Simon Fraser (smfr)]

https://trac.webkit.org/r173702