Bug 136878 – Introduce Promise A+ tests into WebKit

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Yusuke Suzuki]

To ensure WebKit Promise stability, introducing Promise A+ tests[1] into WebKit.
It's also used to test V8 Promise[2].
So the tests guarantee that WebKit Promise's spec validity and interchangeability to the other browser's Promise implementation.

[1]: https://github.com/promises-aplus/promises-tests
[2]: https://code.google.com/p/v8/source/browse#svn%2Ftrunk%2Ftest%2Fpromises-aplus

[Yusuke Suzuki]

Created attachment 238306 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 238306 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238306&action=review

> LayoutTests/ChangeLog:23
> +        So marked the test as a SLOW test.

I'm not sure how to introduce the external code into WebKit. Added license files.
Sam, could you tell me the mannar to do it? I'll fix it :)

[Yusuke Suzuki]

Comment on attachment 238306 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238306&action=review

> LayoutTests/ChangeLog:17
> +        So added SinonJS[4] and browserify's license files into the test directory.

As mentioned here, it uses browserify to transform Node.js style code into browser style code (using sync `require`).
Is it OK? I'd like to hear your opinion.

[Sam Weinig]

Comment on attachment 238306 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238306&action=review

>> LayoutTests/ChangeLog:23
>> +        So marked the test as a SLOW test.
> 
> I'm not sure how to introduce the external code into WebKit. Added license files.
> Sam, could you tell me the mannar to do it? I'll fix it :)

How slow is it?

[Sam Weinig]

(In reply to comment #4)
> (From update of attachment 238306 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=238306&action=review
> 
> >> LayoutTests/ChangeLog:23
> >> +        So marked the test as a SLOW test.
> > 
> > I'm not sure how to introduce the external code into WebKit. Added license files.
> > Sam, could you tell me the mannar to do it? I'll fix it :)
> 
> How slow is it?

Actually, can we split this into multiple tests so that each is not that slow? Otherwise, this all looks good.

[Yusuke Suzuki]

(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 238306 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=238306&action=review
> > 
> > >> LayoutTests/ChangeLog:23
> > >> +        So marked the test as a SLOW test.
> > > 
> > > I'm not sure how to introduce the external code into WebKit. Added license files.
> > > Sam, could you tell me the mannar to do it? I'll fix it :)
> > 
> > How slow is it?
> 
> Actually, can we split this into multiple tests so that each is not that slow? Otherwise, this all looks good.

Thank you for your review!
Maybe I think we can split it into several files. So I'll do so :)

[Yusuke Suzuki]

Created attachment 239108 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 239108 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239108&action=review

I've updated the patch. In this patch, I've splitted the whole test into per-file tests.

> LayoutTests/ChangeLog:23
> +        So mark it as a Slow test.

I've splitted the whole tests into per file tests. So almost all tests become fast.
However, only tests-2-3-3 has a lot of test cases and it sometimes exceeds the time limit.
For example, in my environment (GTK debug build on Ubuntu 14.04), it takes about 13s.
So marked it as a Slow test.

[WebKit Commit Bot]

Comment on attachment 239108 [details]
Patch

Clearing flags on attachment: 239108

Committed r174307: <http://trac.webkit.org/changeset/174307>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.