Bug 136874 - [Win] __BUILD_NUMBER_SHORT__ not defined
Summary: [Win] __BUILD_NUMBER_SHORT__ not defined
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-16 15:28 PDT by Alex Christensen
Modified: 2024-03-10 19:20 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.34 KB, patch)
2014-09-16 15:31 PDT, Alex Christensen 		bfulgham: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2014-09-16 15:28:49 PDT 
Recently when compiling WinCairo, I'm getting this error:
     1>..\..\win\WebKit.resources\WebKit.rc(51): error RC2104: undefined keyword or key name: __BUILD_NUMBER_SHORT__

I'm not sure why it's there, but getting rid of it fixes my problem.  Does it break anything else?
Comment 1 Alex Christensen 2014-09-16 15:31:03 PDT 
Created attachment 238216 [details]
Patch
Comment 2 Brent Fulgham 2014-09-19 17:06:21 PDT 
Comment on attachment 238216 [details]
Patch

__BUILD_NUMBER_SHORT_ should be created by auto-version.pl (and defined in "autoversion.h"). We don't want to make the change you propose. Most likely you just need to make sure auto-version.pl runs during the build to create the necessary autoversion.h file.
Comment 3 Ahmad Saleem 2024-03-10 19:20:32 PDT 
If not mistaken this file is gone with: https://commits.webkit.org/260397@main

Marking this as 'RESOLVED CONFIGURATION CHANGED', please reopen, if I am wrong.