Bug 136866 - Exclude page visibility from PageThrottler's hysteresis
Summary: Exclude page visibility from PageThrottler's hysteresis
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-16 13:36 PDT by Gavin Barraclough
Modified: 2014-09-17 09:32 PDT (History)
0 users

See Also:


Attachments
Fix (6.52 KB, patch)
2014-09-16 13:43 PDT, Gavin Barraclough
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2014-09-16 13:36:51 PDT
Including visibility in the hysteresis mechanism has the effect of prolonging the visually idle timeout, and causing the page hide event to be run at foreground priority. Neither of these are particularly desirable. Instead separate visibility from the rest of the page activities we track (and apply hysteresis to), and feed this directly into determination of the UserActivity state.
Comment 1 Gavin Barraclough 2014-09-16 13:43:37 PDT
Created attachment 238205 [details]
Fix
Comment 2 Geoffrey Garen 2014-09-16 13:51:56 PDT
Comment on attachment 238205 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=238205&action=review

r=me

> Source/WebCore/page/PageThrottler.cpp:78
> +    // Allow throttling if there is no page activity, and the page is viibly idle.

"visually"

> Source/WebCore/platform/HysteresisActivity.h:37
> +    Waiting,

I wonder if "Waiting" would be clearer if it said what it was waiting for. Maybe "WaitingToStop" or "WillStop" "WillStopAfterDelay" or "WillStopSoon".
Comment 3 Gavin Barraclough 2014-09-17 09:32:57 PDT
Committed revision 173693.