RESOLVED FIXED136856
Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests (II) 
https://bugs.webkit.org/show_bug.cgi?id=136856
Summary Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests (II)
Csaba Osztrogonác
Reported 2014-09-16 07:13:13 PDT
The original failure count introduced in: https://trac.webkit.org/changeset/166608 https://trac.webkit.org/changeset/161461 And the http://trac.webkit.org/changeset/172829 tried to fixed the buggy failure counter, but it turned out it isn't enough, because the regexp should respect the 4 spaces at the beginning.
Attachments
Patch (4.38 KB, patch)
2014-09-16 07:25 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2014-09-16 07:25:16 PDT
Created attachment 238179 [details] Patch
WebKit Commit Bot
Comment 2 2014-09-16 07:27:30 PDT
Attachment 238179 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:157: [RunLLINTCLoopTestsTest.test_failures] Undefined variable 'FAILURE' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:160: [RunLLINTCLoopTestsTest.test_failure] Undefined variable 'FAILURE' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:163: [RunLLINTCLoopTestsTest.test_no_failure] Undefined variable 'SUCCESS' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:178: [Run32bitJSCTestsTest.test_failures] Undefined variable 'FAILURE' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:181: [Run32bitJSCTestsTest.test_failure] Undefined variable 'FAILURE' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:184: [Run32bitJSCTestsTest.test_no_failure] Undefined variable 'SUCCESS' [pylint/E0602] [5] Total errors found: 6 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 3 2014-09-18 10:15:14 PDT
Comment on attachment 238179 [details] Patch Clearing flags on attachment: 238179 Committed r173725: <http://trac.webkit.org/changeset/173725>
WebKit Commit Bot
Comment 4 2014-09-18 10:15:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.