Bug 136844 - Rename LiveNodeLists / HTMLCollections's nodeMatches() to elementMatches()
Summary: Rename LiveNodeLists / HTMLCollections's nodeMatches() to elementMatches()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-15 16:53 PDT by Chris Dumez
Modified: 2014-09-17 17:42 PDT (History)
3 users (show)

See Also:

Attachments
Patch (21.39 KB, patch)
2014-09-15 16:55 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-09-15 16:53:27 PDT 
Rename LiveNodeLists / HTMLCollections's nodeMatches() to elementMatches() for clarity as the argument is an Element.
Comment 1 Chris Dumez 2014-09-15 16:55:13 PDT 
Created attachment 238148 [details]
Patch
Comment 2 WebKit Commit Bot 2014-09-15 22:36:50 PDT 
Comment on attachment 238148 [details]
Patch

Clearing flags on attachment: 238148

Committed r173649: <http://trac.webkit.org/changeset/173649>
Comment 3 WebKit Commit Bot 2014-09-15 22:36:54 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Darin Adler 2014-09-17 17:23:08 PDT 
Comment on attachment 238148 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238148&action=review

> Source/WebCore/dom/ClassNodeList.h:49
> +    virtual bool elementMatches(Element*) const override;

Since we are touching every single call site, it really seems we’d want to change this to Element&. Too late!
Comment 5 Chris Dumez 2014-09-17 17:42:24 PDT 
Comment on attachment 238148 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238148&action=review

>> Source/WebCore/dom/ClassNodeList.h:49
>> +    virtual bool elementMatches(Element*) const override;
> 
> Since we are touching every single call site, it really seems we’d want to change this to Element&. Too late!

Right, sorry about that. I'll follow-up on this.