Bug 136841 - Implement cap height in SimpleFontDataWin to enable initial-letter support for Windows
Summary: Implement cap height in SimpleFontDataWin to enable initial-letter support fo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on: 136484
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-15 15:02 PDT by Roger Fong
Modified: 2014-09-22 11:35 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.94 KB, patch)
2014-09-22 11:28 PDT, Brent Fulgham
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Fong 2014-09-15 15:02:46 PDT
In https://bugs.webkit.org/show_bug.cgi?id=136484 initial-letter support was enabled for Mac and iOS but not the other platforms.
In order to enable we have to implement the cap height logic in SimpleFontDataWin.

Until then, skipping all initial-letter tests
Comment 1 Brent Fulgham 2014-09-19 17:52:59 PDT
I'm testing a patch for this. Easy fix.
Comment 2 Brent Fulgham 2014-09-22 11:28:17 PDT
Created attachment 238489 [details]
Patch
Comment 3 Radar WebKit Bug Importer 2014-09-22 11:29:24 PDT
<rdar://problem/18415046>
Comment 4 Dave Hyatt 2014-09-22 11:32:47 PDT
Comment on attachment 238489 [details]
Patch

r=me
Comment 5 Brent Fulgham 2014-09-22 11:35:37 PDT
Committed r173840: <http://trac.webkit.org/changeset/173840>