Bug 136823 - JSC test gardening
Summary: JSC test gardening
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-15 07:35 PDT by Csaba Osztrogonác
Modified: 2014-09-16 02:02 PDT (History)
3 users (show)

See Also:


Attachments
Patch (5.03 KB, patch)
2014-09-15 07:39 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2014-09-15 07:35:07 PDT
JSC Mozilla tests - with --no-jsc-stress option
-------------------------------------------------
ecma/Date/15.9.5.31-1.js fails on the Windows bot (unskipped by https://trac.webkit.org/changeset/173116)
--> It should be skipped only on Windows.

ecma/Date/15.9.2.1.js
ecma/Date/15.9.2.2-1.js
ecma/Date/15.9.2.2-2.js
ecma/Date/15.9.2.2-3.js
ecma/Date/15.9.2.2-4.js
ecma/Date/15.9.2.2-5.js
ecma/Date/15.9.2.2-6.js
--> Skipped everywhere now, but they are passing on Mac and Linux. Should be skipped only on Windows

ecma_3/Date/15.9.5.6.js
--> Passes on Linux and Mac, it can be unskipped.

ecma_3/Date/15.9.5.7.js
--> Still fails on Linux and Mac, it should be skipped only on non Mac platforms.


JSC stress tests
-----------------
ecma/Date/15.9.2.1.js
ecma/Date/15.9.2.2-1.js
ecma/Date/15.9.2.2-2.js
ecma/Date/15.9.2.2-3.js
ecma/Date/15.9.2.2-4.js
ecma/Date/15.9.2.2-5.js
ecma/Date/15.9.2.2-6.js
--> Pass on Linux and Mac, they can be unskipped. (Windows doesn't support stress tests)

ecma/Date/15.9.5.14.js
ecma/Date/15.9.5.31-1.js
ecma/Date/15.9.5.34-1.js
--> Pass on Linux and Mac, they can be unskipped. (after https://trac.webkit.org/changeset/173116)
Comment 1 Csaba Osztrogonác 2014-09-15 07:37:53 PDT
(In reply to comment #0)
> ecma_3/Date/15.9.5.7.js
> --> Still fails on Linux and Mac, it should be skipped only on non Mac platforms.

typo fix: non Windows
Comment 2 Csaba Osztrogonác 2014-09-15 07:39:00 PDT
Created attachment 238127 [details]
Patch
Comment 3 Geoffrey Garen 2014-09-15 11:13:30 PDT
Comment on attachment 238127 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2014-09-16 01:47:33 PDT
Comment on attachment 238127 [details]
Patch

Rejecting attachment 238127 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 238127, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
og
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/JavaScriptCore/tests/mozilla/mozilla-tests.yaml
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/Scripts/run-javascriptcore-tests
Hunk #2 FAILED at 51.
1 out of 2 hunks FAILED -- saving rejects to file Tools/Scripts/run-javascriptcore-tests.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Geoffrey Garen']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/5864471264231424
Comment 5 Csaba Osztrogonác 2014-09-16 02:01:18 PDT
Landed in https://trac.webkit.org/changeset/173656 after resolving the
conflict caused by https://trac.webkit.org/changeset/173637