Bug 136822 - [EFL] Ecore and Eina are initialized twice in TestWebKitAPI
Summary: [EFL] Ecore and Eina are initialized twice in TestWebKitAPI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Grzegorz Czajkowski
URL:
Keywords:
Depends on: 135606
Blocks:
  Show dependency tree / graph
 
Reported: 2014-09-15 05:56 PDT by Grzegorz Czajkowski
Modified: 2014-09-15 07:45 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.73 KB, patch)
2014-09-15 05:57 PDT, Grzegorz Czajkowski 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Grzegorz Czajkowski 2014-09-15 05:56:14 PDT 
In TestWebKitAPI/efl/main.cpp, ecore and eina modules are unnecessarily initialized as we already does it in PlatformWebView::PlatformWebView calling ewk_init(). The reason for that was to ensure testing for example, WTF where creating the view is not mandatory.

Call ewk_init() and ewk_shutdown() in TestWebKitAPI/efl/main.cpp in order to properly initalize and release EWebKit.
Comment 1 Grzegorz Czajkowski 2014-09-15 05:57:35 PDT 
Created attachment 238123 [details]
Patch
Comment 2 Gyuyoung Kim 2014-09-15 07:08:58 PDT 
Comment on attachment 238123 [details]
Patch

LGTM. r=me.
Comment 3 WebKit Commit Bot 2014-09-15 07:45:40 PDT 
Comment on attachment 238123 [details]
Patch

Clearing flags on attachment: 238123

Committed r173621: <http://trac.webkit.org/changeset/173621>
Comment 4 WebKit Commit Bot 2014-09-15 07:45:44 PDT 
All reviewed patches have been landed.  Closing bug.