Bug 136819 - Move DragController::createFragmentFromDragData implementation to the editor
Summary: Move DragController::createFragmentFromDragData implementation to the editor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 136802
Blocks:
  Show dependency tree / graph
 
Reported: 2014-09-15 05:02 PDT by Carlos Garcia Campos
Modified: 2014-10-04 01:38 PDT (History)
1 user (show)

See Also:

Attachments
Patch (15.34 KB, patch)
2014-09-15 05:09 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Updated patch (16.17 KB, patch)
2014-09-17 00:24 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Try to fix windows build (16.22 KB, patch)
2014-09-17 01:19 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Try to fix EFL build (16.42 KB, patch)
2014-09-17 02:03 PDT, Carlos Garcia Campos 		darin: review+
Details | Formatted Diff | Diff
Patch for landing (16.36 KB, patch)
2014-10-04 00:44 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2014-09-15 05:02:39 PDT 
And use the editor from the DragController instead.
Comment 1 Carlos Garcia Campos 2014-09-15 05:09:06 PDT 
Created attachment 238117 [details]
Patch
Comment 2 Carlos Garcia Campos 2014-09-17 00:24:27 PDT 
Created attachment 238239 [details]
Updated patch

Rebased, it should apply now
Comment 3 Carlos Garcia Campos 2014-09-17 01:19:13 PDT 
Created attachment 238240 [details]
Try to fix windows build
Comment 4 Carlos Garcia Campos 2014-09-17 02:03:10 PDT 
Created attachment 238243 [details]
Try to fix EFL build
Comment 5 Carlos Garcia Campos 2014-09-29 00:32:29 PDT 
Ping :-)
Comment 6 Darin Adler 2014-10-03 09:05:46 PDT 
Comment on attachment 238243 [details]
Try to fix EFL build

View in context: https://bugs.webkit.org/attachment.cgi?id=238243&action=review

A good step in the right direction. I suspect we can keep refactoring this to make the code even tighter over time.

> Source/WebCore/editing/win/EditorWin.cpp:51
> +template <typename PlatformDragData>
> +static PassRefPtr<DocumentFragment> createFragmentFromPlatformData(PlatformDragData* platformDragData, Frame& frame)

Should take PlatformDragData& instead of PlatformDragData*.

I’m also surprised this needs to be a template. Are all four functions called here really overloaded for two different types!?
Comment 7 Carlos Garcia Campos 2014-10-03 09:18:44 PDT 
(In reply to comment #6)
> (From update of attachment 238243 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=238243&action=review
> 
> A good step in the right direction. I suspect we can keep refactoring this to make the code even tighter over time.

Thanks for the review.

> > Source/WebCore/editing/win/EditorWin.cpp:51
> > +template <typename PlatformDragData>
> > +static PassRefPtr<DocumentFragment> createFragmentFromPlatformData(PlatformDragData* platformDragData, Frame& frame)
> 
> Should take PlatformDragData& instead of PlatformDragData*.

Sure.

> I’m also surprised this needs to be a template. Are all four functions called here really overloaded for two different types!?

Yes.
Comment 8 Carlos Garcia Campos 2014-10-04 00:44:26 PDT 
Created attachment 239271 [details]
Patch for landing

Not sure the windows changes are correct...
Comment 9 Carlos Garcia Campos 2014-10-04 01:38:09 PDT 
Committed r174314: <http://trac.webkit.org/changeset/174314>