Bug 136793 - Multiple EWS or commit bots can pick up processing of the same patch
Summary: Multiple EWS or commit bots can pick up processing of the same patch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-12 16:13 PDT by Alexey Proskuryakov
Modified: 2014-09-12 16:33 PDT (History)
1 user (show)

See Also:

Attachments
proposed fix (2.29 KB, patch)
2014-09-12 16:16 PDT, Alexey Proskuryakov 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-09-12 16:13:46 PDT 
Only one bot from each queue is supposed to be processing a given patch; havoc ensues otherwise.

But this happens pretty frequently. Turns out that the server doesn't let a bot chew on a patch for more than an hour, and releases it for other bots to take.

In worst case, a bot needs to clean, update, apply the patch, build, test, re-test, rollout, build, test, commit. That takes more than an hour.
Comment 1 Alexey Proskuryakov 2014-09-12 16:16:50 PDT 
Created attachment 238072 [details]
proposed fix
Comment 2 Alexey Proskuryakov 2014-09-12 16:33:25 PDT 
Committed <http://trac.webkit.org/r173587>.