All bots abort after 50 crashes or 500 failures, nobody uses this feature.
Created attachment 238022 [details]
Comment on attachment 238022 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=238022&action=review
> - self.setCommand(self.command + ["--exit-after-n-crashes-or-timeouts", "50", "--exit-after-n-failures", "500"])
This line shouldn't be removed, we need --exit-after-* unconditionally. (shouldAbortEarly is always True)
Created attachment 238126 [details]
This property was introduced in http://trac.webkit.org/changeset/126044 and
the WTR bug was fixed by http://trac.webkit.org/changeset/126418 in 3 days.
It happened 2 years before, since then we didn't need this hack to make bots
not to exit early. So let's remove it.
On a serious regression exit after 50 timeout is really necessary until the
culprit patch is rolled out. 50 timeouts take 50*35s = 1750s = 29.16mins on
WK1 and 50*80s = 66.66mins on WK2. If we disabled the early exit, it would
cause infinite builds on the bots.
If we will really need this hack in the future, I prefer adding
it back as per builder configurable option, like SVNMirror.
Comment on attachment 238126 [details]
Clearing flags on attachment: 238126
Committed r173653: <http://trac.webkit.org/changeset/173653>
All reviewed patches have been landed. Closing bug.