paths that should trigger: inspector generator: Source/JavaScriptCore/inspector/scripts/codegen/ replay input generator: Source/JavaScriptCore/replay/scripts/
Relevant scripts: Tools/Scripts/run-inspector-generator-tests Tools/Scripts/run-input-generator-tests
<rdar://problem/18324319>
Created attachment 238058 [details] Patch
Comment on attachment 238058 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238058&action=review > Tools/Scripts/webkitpy/common/config/watchlist:203 > + "filename": r"Source/JavaScriptCore/inspector/scripts/codegen", We may also want the generator script itself: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py > Tools/Scripts/webkitpy/common/config/watchlist:394 > + "WebReplayGenerator": [ "This patch modifies the WEB_REPLAY inputs generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-input-generator-tests --reset-results`)" ] Throw a trailing comma! The others have it, and it makes future diffs much nicer =)
(In reply to comment #4) > (From update of attachment 238058 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=238058&action=review > > > Tools/Scripts/webkitpy/common/config/watchlist:203 > > + "filename": r"Source/JavaScriptCore/inspector/scripts/codegen", > > We may also want the generator script itself: > > Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py > > > Tools/Scripts/webkitpy/common/config/watchlist:394 > > + "WebReplayGenerator": [ "This patch modifies the WEB_REPLAY inputs generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-input-generator-tests --reset-results`)" ] > > Throw a trailing comma! The others have it, and it makes future diffs much nicer =) OK
Committed r173594: <http://trac.webkit.org/changeset/173594>