Bug 136753 - [MIPS] abortWithReason missing
Summary: [MIPS] abortWithReason missing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Julien Brianceau
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-11 13:10 PDT by Alberto Garcia
Modified: 2016-01-07 09:06 PST (History)
6 users (show)

See Also:


Attachments
Add two missing abortWithReason implementations in mips macro assembler (1.56 KB, patch)
2016-01-07 08:02 PST, Julien Brianceau
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2014-09-11 13:10:19 PDT
This is a follow-up to bug 136696.

abortWithReason() is missing for MIPS, what results in the following errors:

Source/JavaScriptCore/yarr/YarrJIT.cpp:1647:56: error: there are no arguments to 'abortWithReason' that depend on a template parameter, so a declaration of 'abortWithReason' must be available [-fpermissive]
Source/JavaScriptCore/yarr/YarrJIT.cpp:1703:56: error: there are no arguments to 'abortWithReason' that depend on a template parameter, so a declaration of 'abortWithReason' must be available [-fpermissive]
Source/JavaScriptCore/yarr/YarrJIT.cpp:1647:56: error: 'abortWithReason' was not declared in this scope
Source/JavaScriptCore/yarr/YarrJIT.cpp:1703:56: error: 'abortWithReason' was not declared in this scope
Source/JavaScriptCore/yarr/YarrJIT.cpp:1647:56: error: 'abortWithReason' was not declared in this scope
Source/JavaScriptCore/yarr/YarrJIT.cpp:1703:56: error: 'abortWithReason' was not declared in this scope

All this is happening if I disable the JIT compiler, if I try to enable it then there's several other missing functions and methods. I understand that it's not supported in MIPS?
Comment 1 Julien Brianceau 2016-01-07 08:02:32 PST
Created attachment 268452 [details]
Add two missing abortWithReason implementations in mips macro assembler
Comment 2 WebKit Commit Bot 2016-01-07 09:06:21 PST
Comment on attachment 268452 [details]
Add two missing abortWithReason implementations in mips macro assembler

Clearing flags on attachment: 268452

Committed r194699: <http://trac.webkit.org/changeset/194699>
Comment 3 WebKit Commit Bot 2016-01-07 09:06:26 PST
All reviewed patches have been landed.  Closing bug.