Bug 136746 – Use tighter typing for Document::ownerElement() return value

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

Use tighter typing for Document::ownerElement() return value to improve code readability and allow to compiler to generate slightly more efficient code is some cases.

[Chris Dumez]

Created attachment 237970 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 237970 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 237970 [details]
Patch

Clearing flags on attachment: 237970

Committed r173528: <http://trac.webkit.org/changeset/173528>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 237970 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237970&action=review

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1464
> +    if (HTMLFrameOwnerElement* owner = document->ownerElement()) {

auto* is better than HTMLFrameOwnerElement here; if we had used auto before then the code would have been closer to correct without modifying it

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1466
> +            const AtomicString& title = owner->getAttribute(titleAttr);

fastGetAttribute

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1477
> +    if (HTMLElement* body = document->body())

I think auto* is better than HTMLElement here. Maybe some day we will have an HTMLBodyElement, and maybe it will have some special optimization for getNameAttribute. Why not be future proof in this respect?