Bug 136739 – [EFL][WK2] Minibrowser : Support Zoom on Control key + scroll

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Tanay]

Support the following behaviour in Minibrowser:
1) Zoom in on mouse scroll up
2) Zoom out on mouse scroll down

[Tanay]

Created attachment 238105 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 238105 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238105&action=review

> Tools/MiniBrowser/efl/main.c:312
> +        if (ev->z == -1 && zoom_level_set(ewk_view, window->current_zoom_level + 1)) {

Isn't ewk_view same with window->ewk_view ? If so, how about using window->ewk_view instead of ewk_view for readability ?

[Tanay]

Created attachment 238241 [details]
Patch

[Tanay]

(In reply to comment #2)
> (From update of attachment 238105 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=238105&action=review
> 
> > Tools/MiniBrowser/efl/main.c:312
> > +        if (ev->z == -1 && zoom_level_set(ewk_view, window->current_zoom_level + 1)) {
> 
> Isn't ewk_view same with window->ewk_view ? If so, how about using window->ewk_view instead of ewk_view for readability ?

Thanks for pointing that out.
I notice that if I use the window->ewk_view then the scroll event is not consumed by the view. So scrolling still remains active along with zoom.
 
To avoid this we should use the ewk_view instance passed back in the parameter so that the framework knows that event has been consumed. I have made this uniform and I am using ewk_view for all the API calls in on_mouse_wheel callback.

[Gyuyoung Kim]

Comment on attachment 238241 [details]
Patch

LGTM.

[WebKit Commit Bot]

Comment on attachment 238241 [details]
Patch

Clearing flags on attachment: 238241

Committed r173750: <http://trac.webkit.org/changeset/173750>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.