Bug 136734 – Check for varying packing restrictions per program instead of per shader

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Roger Fong]

rdar://problem/16308409

[Roger Fong]

Created attachment 237931 [details]
patch

[WebKit Commit Bot]

Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE

[Roger Fong]

The spec says:

If the packing algorithm fails either for the uniform variables of a shader or for the varying variables of a program, compilation or linking must fail.

I originally understood compilation to mean, the shaders fail to compile (since you don't compile a program, you just link it). But in this case, I think compilation means the same thing as linking.

[Roger Fong]

Created attachment 237961 [details]
patch

with build fix

[Dean Jackson]

Comment on attachment 237961 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237961&action=review

> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:368
> +        const char* builtIns[] = {
> +            "gl_FragCoord",
> +            "gl_FrontFacing",
> +            "gl_PointCoord"
> +        };
> +
> +        bool isBuiltIn = false;
> +        for (int i = 0; i < 3; ++i) {
> +            if (symbolName == builtIns[i]) {
> +                isBuiltIn = true;
> +                break;
> +            }
> +        }
> +
> +        if (isBuiltIn)
> +            continue;

I don't really have a preference here, but maybe it might be simpler to do if (symbolName == "gl_FragCoord" || symbolName ==...) continue;

[Roger Fong]

Took Dean's suggestion.

Committed:
http://trac.webkit.org/changeset/173527