Bug 136721 – Rename activation to be more in line with spec language

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Oliver Hunt]

Rename activation to be more in line with spec language

[Oliver Hunt]

Created attachment 237960 [details]
Patch

[WebKit Commit Bot]

Attachment 237960 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/Arguments.h:30:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/JavaScriptCore/debugger/DebuggerCallFrame.cpp:37:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/JavaScriptCore/interpreter/CallFrame.cpp:32:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:41:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/JavaScriptCore/runtime/JSLexicalEnvironment.cpp:34:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/JavaScriptCore/debugger/DebuggerScope.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:40:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/JavaScriptCore/runtime/JSLexicalEnvironment.h:28:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/runtime/JSLexicalEnvironment.h:117:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/JavaScriptCore/runtime/JSLexicalEnvironment.h:119:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
Total errors found: 10 in 52 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Oliver Hunt]

These errors are either pre-existing (i don't want o change too much) or related to our inlines file that needs to be after other includes so is typically out of order.

(In reply to comment #2)
> Attachment 237960 [details] did not pass style-queue:
> 
> 
> ERROR: Source/JavaScriptCore/runtime/Arguments.h:30:  Alphabetical sorting problem.  [build/include_order] [4]
> ERROR: Source/JavaScriptCore/debugger/DebuggerCallFrame.cpp:37:  Alphabetical sorting problem.  [build/include_order] [4]
> ERROR: Source/JavaScriptCore/interpreter/CallFrame.cpp:32:  Alphabetical sorting problem.  [build/include_order] [4]
> ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:41:  Alphabetical sorting problem.  [build/include_order] [4]
> ERROR: Source/JavaScriptCore/runtime/JSLexicalEnvironment.cpp:34:  Alphabetical sorting problem.  [build/include_order] [4]
> ERROR: Source/JavaScriptCore/debugger/DebuggerScope.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
> ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:40:  Alphabetical sorting problem.  [build/include_order] [4]
> ERROR: Source/JavaScriptCore/runtime/JSLexicalEnvironment.h:28:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> ERROR: Source/JavaScriptCore/runtime/JSLexicalEnvironment.h:117:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
> ERROR: Source/JavaScriptCore/runtime/JSLexicalEnvironment.h:119:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
> Total errors found: 10 in 52 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

[Michael Saboff]

Comment on attachment 237960 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237960&action=review

r=me

> Source/JavaScriptCore/bytecode/CallVariant.h:41
> +//     instance, that is associated with a particular lexical environment. This pinpoints not just the code

Reflow the comment so that all lines break about the same length.

> Source/JavaScriptCore/debugger/DebuggerScope.cpp:168
> +    // lexical environment object. Hence, a lexical environment object implies a function or eval scope.

Reflow the comment line breaks.

> Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:473
> +    // a lexical environment object, the lexical environment object will only be set up after

Reflow the comment line breaks.

> Source/JavaScriptCore/runtime/Arguments.cpp:388
> +    // If we have a captured argument that logically aliases lexical environment storage,
> +    // but we optimize away the lexicalEnvironment, the argument needs to tear off into

Reflow the comment line breaks.

> Source/JavaScriptCore/runtime/JSLexicalEnvironment.cpp:2
> + * Copyright (C) 2008, 2009 Apple Inc. All rights reserved.

Add 2014

> Source/JavaScriptCore/runtime/JSLexicalEnvironment.h:2
> + * Copyright (C) 2008, 2009, 2013 Apple Inc. All rights reserved.

Add 2014

[Oliver Hunt]

Committed r173517: <http://trac.webkit.org/changeset/173517>