Bug 136720 - [SVG] Cleanup iterator code in SMILTimeContainer using range-based loop
Summary: [SVG] Cleanup iterator code in SMILTimeContainer using range-based loop
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P4 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-10 15:48 PDT by Adenilson Cavalcanti Silva
Modified: 2014-09-10 21:02 PDT (History)
9 users (show)

See Also:


Attachments
Patch (2.32 KB, patch)
2014-09-10 15:49 PDT, Adenilson Cavalcanti Silva
no flags Details | Formatted Diff | Diff
Addressing the spaces issue. (2.60 KB, patch)
2014-09-10 19:50 PDT, Adenilson Cavalcanti Silva
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adenilson Cavalcanti Silva 2014-09-10 15:48:30 PDT
Use some C++11 goodness to cleanup iterator loops.
Comment 1 Adenilson Cavalcanti Silva 2014-09-10 15:49:46 PDT
Created attachment 237913 [details]
Patch
Comment 2 Filip Pizlo 2014-09-10 19:32:41 PDT
Comment on attachment 237913 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237913&action=review

> Source/WebCore/svg/animation/SMILTimeContainer.cpp:191
> +        for (auto& it : m_scheduledAnimations) {

There is something funky going on with indentation here - is that a hardware tab?
Comment 3 Filip Pizlo 2014-09-10 19:33:24 PDT
(In reply to comment #2)
> (From update of attachment 237913 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=237913&action=review
> 
> > Source/WebCore/svg/animation/SMILTimeContainer.cpp:191
> > +        for (auto& it : m_scheduledAnimations) {
> 
> There is something funky going on with indentation here - is that a hardware tab?

Looks like spaces, but still, I think that this should be indented only 4 spaces.
Comment 4 Adenilson Cavalcanti Silva 2014-09-10 19:50:02 PDT
Created attachment 237928 [details]
Addressing the spaces issue.
Comment 5 WebKit Commit Bot 2014-09-10 21:02:05 PDT
Comment on attachment 237928 [details]
Addressing the spaces issue.

Clearing flags on attachment: 237928

Committed r173506: <http://trac.webkit.org/changeset/173506>
Comment 6 WebKit Commit Bot 2014-09-10 21:02:11 PDT
All reviewed patches have been landed.  Closing bug.