Bug 136720 – [SVG] Cleanup iterator code in SMILTimeContainer using range-based loop

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Adenilson Cavalcanti Silva]

Use some C++11 goodness to cleanup iterator loops.

[Adenilson Cavalcanti Silva]

Created attachment 237913 [details]
Patch

[Filip Pizlo]

Comment on attachment 237913 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237913&action=review

> Source/WebCore/svg/animation/SMILTimeContainer.cpp:191
> +        for (auto& it : m_scheduledAnimations) {

There is something funky going on with indentation here - is that a hardware tab?

[Filip Pizlo]

(In reply to comment #2)
> (From update of attachment 237913 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=237913&action=review
> 
> > Source/WebCore/svg/animation/SMILTimeContainer.cpp:191
> > +        for (auto& it : m_scheduledAnimations) {
> 
> There is something funky going on with indentation here - is that a hardware tab?

Looks like spaces, but still, I think that this should be indented only 4 spaces.

[Adenilson Cavalcanti Silva]

Created attachment 237928 [details]
Addressing the spaces issue.

[WebKit Commit Bot]

Comment on attachment 237928 [details]
Addressing the spaces issue.

Clearing flags on attachment: 237928

Committed r173506: <http://trac.webkit.org/changeset/173506>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.