[Curl] Optimization; avoid reallocating string many times.

Adding individual characters to a string is inefficient, the string will be reallocated each time.

Created attachment 237889 [details]
Patch

[Alex Christensen]

Comment on attachment 237889 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237889&action=review

> Source/WebCore/platform/network/curl/CookieJarCurl.cpp:42
> +    token = WTF::move(strToken);

Couldn't this be token=String(cookieStart, cookie - cookieStart) to avoid two lines and a move?

Created attachment 237893 [details]
Patch

(In reply to comment #2)
> (From update of attachment 237889 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=237889&action=review
> 
> > Source/WebCore/platform/network/curl/CookieJarCurl.cpp:42
> > +    token = WTF::move(strToken);
> 
> Couldn't this be token=String(cookieStart, cookie - cookieStart) to avoid two lines and a move?

Yes, thank you, updated patch :)

[WebKit Commit Bot]

Comment on attachment 237893 [details]
Patch

Clearing flags on attachment: 237893

Committed r173474: <http://trac.webkit.org/changeset/173474>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.