RESOLVED FIXED 136704
[Curl] Optimization; avoid reallocating string many times. 
https://bugs.webkit.org/show_bug.cgi?id=136704
Summary [Curl] Optimization; avoid reallocating string many times.
peavo
Reported 2014-09-10 06:47:07 PDT
Adding individual characters to a string is inefficient, the string will be reallocated each time.
Attachments
Patch (1.54 KB, patch)
2014-09-10 06:51 PDT, peavo 		no flags
DetailsFormatted DiffDiff
Patch (1.51 KB, patch)
2014-09-10 09:09 PDT, peavo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
peavo
Comment 1 2014-09-10 06:51:25 PDT
Created attachment 237889 [details] Patch
Alex Christensen
Comment 2 2014-09-10 08:29:23 PDT
Comment on attachment 237889 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237889&action=review > Source/WebCore/platform/network/curl/CookieJarCurl.cpp:42 > + token = WTF::move(strToken); Couldn't this be token=String(cookieStart, cookie - cookieStart) to avoid two lines and a move?
peavo
Comment 3 2014-09-10 09:09:08 PDT
Created attachment 237893 [details] Patch
peavo
Comment 4 2014-09-10 09:09:40 PDT
(In reply to comment #2) > (From update of attachment 237889 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=237889&action=review > > > Source/WebCore/platform/network/curl/CookieJarCurl.cpp:42 > > + token = WTF::move(strToken); > > Couldn't this be token=String(cookieStart, cookie - cookieStart) to avoid two lines and a move? Yes, thank you, updated patch :)
WebKit Commit Bot
Comment 5 2014-09-10 11:10:54 PDT
Comment on attachment 237893 [details] Patch Clearing flags on attachment: 237893 Committed r173474: <http://trac.webkit.org/changeset/173474>
WebKit Commit Bot
Comment 6 2014-09-10 11:10:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.