Bug 136700 - [GTK] Merge WebKitAuthenticationWidget into WebKitAuthenticationDialog
Summary: [GTK] Merge WebKitAuthenticationWidget into WebKitAuthenticationDialog
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: Gtk
Depends on:
Blocks: 136615
  Show dependency treegraph
Reported: 2014-09-10 04:08 PDT by Carlos Garcia Campos
Modified: 2014-09-11 02:00 PDT (History)
10 users (show)

See Also:

Patch (26.61 KB, patch)
2014-09-10 04:13 PDT, Carlos Garcia Campos
svillar: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2014-09-10 04:08:11 PDT
The only reason why we had this widget separated in WebCore was to share it between WebKit1 and WebKit2, but now it's only used by WebKitAuthenticationDialog. We can just merge it, and remove another unneeded file from WebCorePlatformGTK.
Comment 1 Carlos Garcia Campos 2014-09-10 04:13:27 PDT
Created attachment 237885 [details]
Comment 2 WebKit Commit Bot 2014-09-10 04:15:18 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Sergio Villar Senin 2014-09-11 01:03:04 PDT
Comment on attachment 237885 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=237885&action=review


> Source/WebKit2/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:58
> +

We might consider doing this in one line.
Comment 4 Carlos Garcia Campos 2014-09-11 02:00:02 PDT
Committed r173510: <http://trac.webkit.org/changeset/173510>