Bug 136698 - [EFL][WK2] Minibrowser : Shift+Scroll navigate to back or forward url's
Summary: [EFL][WK2] Minibrowser : Shift+Scroll navigate to back or forward url's
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-10 02:15 PDT by Tanay
Modified: 2014-09-10 23:41 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.17 KB, patch)
2014-09-10 02:22 PDT, Tanay 		no flags Details | Formatted Diff | Diff
Patch (3.21 KB, patch)
2014-09-10 21:49 PDT, Tanay 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tanay 2014-09-10 02:15:36 PDT 
Shift + Scroll in the browser should take the actions as follows:
1) User should navigate to previous webpage if he pressed Shift + Scroll Down direction
2) User should navigate to next webpage if he pressed Shift + Scroll Up direction
Comment 1 Tanay 2014-09-10 02:22:15 PDT 
Created attachment 237883 [details]
Patch
Comment 2 Gyuyoung Kim 2014-09-10 21:36:10 PDT 
Comment on attachment 237883 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237883&action=review

> Tools/ChangeLog:3
> +        Shift+Scroll navigate to back or forward url's

Please add [EFL] prefix.
Comment 3 Tanay 2014-09-10 21:49:03 PDT 
Created attachment 237930 [details]
Patch
Comment 4 Gyuyoung Kim 2014-09-10 22:01:32 PDT 
Comment on attachment 237930 [details]
Patch

It seems to me that "shift + scroll" is more proper for zoom in/out. However, I don't have big opinion about it yet. r=me.
Comment 5 Tanay 2014-09-10 22:07:09 PDT 
(In reply to comment #4)
> (From update of attachment 237930 [details])
> It seems to me that "shift + scroll" is more proper for zoom in/out. However, I don't have big opinion about it yet. r=me.

Control + Scroll is the combination used for Zoom in current Web Browsers. We will support that too and upload in a separate patch.
Comment 6 WebKit Commit Bot 2014-09-10 23:41:13 PDT 
Comment on attachment 237930 [details]
Patch

Clearing flags on attachment: 237930

Committed r173508: <http://trac.webkit.org/changeset/173508>
Comment 7 WebKit Commit Bot 2014-09-10 23:41:18 PDT 
All reviewed patches have been landed.  Closing bug.