Bug 136686 – Web Inspector: Fix obscure ESLint warnings and skip directories

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Some issues ESLint found that we should fix for consistency. Also caught at least one bug:

---

UserInterface/Controllers/FormatterContentBuilder.js
  199:53  error  Infix operators must be spaced  space-infix-ops

UserInterface/Models/Color.js
  434:32  error  Infix operators must be spaced                 space-infix-ops
  435:32  error  Infix operators must be spaced                 space-infix-ops
  625:17  error  Infix operators must be spaced                 space-infix-ops

UserInterface/Models/DOMNodeStyles.js
   695:12  error  Expression called with trailing whitespace before semicolon  no-space-before-semi

UserInterface/Views/DOMTreeElement.js
   482:8   error  Expected an assignment or function call and instead saw an expression                          no-unused-expressions
   530:52  error  Infix operators must be spaced                                                                 space-infix-ops
   965:27  error  Infix operators must be spaced                                                                 space-infix-ops
   972:48  error  Infix operators must be spaced                                                                 space-infix-ops

UserInterface/Views/CSSStyleDeclarationTextEditor.js
   533:44  error  Wrapping non-IIFE function literals in parens is unnecessary                                   no-wrap-func

UserInterface/Views/DOMTreeDataGridNode.js
  89:1   error  Unexpected blank line at end of file  eol-last

UserInterface/Views/LayerTreeDataGridNode.js
   95:8   error  Return statement should not contain assignment                                                 no-return-assign

UserInterface/Views/TreeOutline.js
    59:8    error  Keyword "throw" must be followed by whitespace  space-return-throw-case
   101:8    error  Keyword "throw" must be followed by whitespace  space-return-throw-case
   150:8    error  Keyword "throw" must be followed by whitespace  space-return-throw-case
   188:8    error  Keyword "throw" must be followed by whitespace  space-return-throw-case
   192:8    error  Keyword "throw" must be followed by whitespace  space-return-throw-case
   872:63   error  Invalid typeof comparison value                 valid-typeof

UserInterface/Models/Breakpoint.js
  354:68  error  Expected an assignment or function call and instead saw an expression                          no-unused-expressions
  
UserInterface/Views/EditingSupport.js
 82:4   error  Expected an assignment or function call and instead saw an expression  no-unused-expressions
 83:4   error  Expected an assignment or function call and instead saw an expression  no-unused-expressions
 84:4   error  Expected an assignment or function call and instead saw an expression  no-unused-expressions

[Joseph Pecoraro]

Created attachment 237871 [details]
[PATCH] Proposed Fix

This gets us down to just a handful of unique errors which we have all over the place. They should be tackled on their own.

[Joseph Pecoraro]

<http://trac.webkit.org/changeset/173492>