Bug 136679 - Make an UNREACHABLE() macro to wrap unreachable code, to reduce #if-iness
Summary: Make an UNREACHABLE() macro to wrap unreachable code, to reduce #if-iness
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Maciej Stachowiak
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-09 14:08 PDT by Maciej Stachowiak
Modified: 2016-03-14 11:39 PDT (History)
3 users (show)

See Also:

Attachments
Patch (15.61 KB, patch)
2014-09-09 14:11 PDT, Maciej Stachowiak 		no flags Details | Formatted Diff | Diff
Try to make it compile on non-clang platforms (15.61 KB, patch)
2014-09-11 01:41 PDT, Maciej Stachowiak 		no flags Details | Formatted Diff | Diff
Trying again to see if Windows builds (15.62 KB, patch)
2014-09-13 23:16 PDT, Maciej Stachowiak 		bfulgham: review-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2014-09-09 14:08:33 PDT 
Make an UNREACHABLE() macro to wrap unreachable code, to reduce #if-iness
Comment 1 Maciej Stachowiak 2014-09-09 14:11:16 PDT 
Created attachment 237855 [details]
Patch
Comment 2 WebKit Commit Bot 2014-09-09 14:12:37 PDT 
Attachment 237855 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:600:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Maciej Stachowiak 2014-09-11 01:41:35 PDT 
Created attachment 237943 [details]
Try to make it compile on non-clang platforms
Comment 4 WebKit Commit Bot 2014-09-11 01:44:12 PDT 
Attachment 237943 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:600:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Maciej Stachowiak 2014-09-13 23:16:15 PDT 
Created attachment 238089 [details]
Trying again to see if Windows builds
Comment 6 WebKit Commit Bot 2014-09-13 23:17:51 PDT 
Attachment 238089 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:600:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Benjamin Poulain 2014-09-13 23:57:19 PDT 
Shouldn't we just remove the macros completely? The warning was removed, it was breaking random stuff.
Comment 8 Darin Adler 2014-09-14 13:43:22 PDT 
Comment on attachment 238089 [details]
Trying again to see if Windows builds

Windows says “unable to build without patch”, so we need to fix the EWS.
Comment 9 Brent Fulgham 2016-03-14 11:39:34 PDT 
Comment on attachment 238089 [details]
Trying again to see if Windows builds

Can you please update this patch for current sources? EWS should be functional now :-)