Bug 136670 - [GTK] Clean up the WebKit build from unused parameter warning in Webkit2/UIProcess module
Summary: [GTK] Clean up the WebKit build from unused parameter warning in Webkit2/UIPr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-09 07:28 PDT by Rohit
Modified: 2014-09-10 00:21 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.33 KB, patch)
2014-09-09 07:32 PDT, Rohit 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rohit 2014-09-09 07:28:11 PDT 
Clean up WebKit GTK build from usused parameters.

[5046/5519] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/API/gtk/PageClientImpl.cpp.o
../../Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:409:6: warning: unused parameter ‘type’ [-Wunused-parameter]
 void PageClientImpl::didSameDocumentNavigationForMainFrame(SameDocumentNavigationType type)
      ^
[5189/5519] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/__/__/DerivedSources/WebKit2/WebPageMessageReceiver.cpp.o
Comment 1 Rohit 2014-09-09 07:32:40 PDT 
Created attachment 237848 [details]
Patch
Comment 2 WebKit Commit Bot 2014-09-09 07:34:55 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 WebKit Commit Bot 2014-09-10 00:21:29 PDT 
Comment on attachment 237848 [details]
Patch

Clearing flags on attachment: 237848

Committed r173455: <http://trac.webkit.org/changeset/173455>
Comment 4 WebKit Commit Bot 2014-09-10 00:21:32 PDT 
All reviewed patches have been landed.  Closing bug.