Bug 13667 - REGRESSION (r21363): Focus ring too tall
Summary: REGRESSION (r21363): Focus ring too tall
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 523.x (Safari 3)
Hardware: Macintosh OS X 10.4
: P1 Normal
Assignee: Dave Hyatt
URL: data:text/html,<div style="outline: a...
Keywords: HasReduction, LayoutTestFailure, Regression
Depends on:
Blocks:
 
Reported: 2007-05-10 15:58 PDT by mitz
Modified: 2007-05-10 16:20 PDT (History)
1 user (show)

See Also:


Attachments
Fix focus rings for continuations to account for collapsing through other blocks when inlines are empty (1.21 KB, patch)
2007-05-10 16:08 PDT, Dave Hyatt
bdakin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2007-05-10 15:58:17 PDT
See URL. Also responsible for this failure <http://build.webkit.org/results/post-commit-pixel-powerpc-mac-os-x/4047/editing/pasteboard/paste-pre-002-diffs.html> and a few others.
Comment 1 Dave Hyatt 2007-05-10 16:08:19 PDT
Created attachment 14478 [details]
Fix focus rings for continuations to account for collapsing through other blocks when inlines are empty

A block in the middle of a continuation should only include its collapsed margins if they aren't going to collapse beyond the inlines above/below.

This is covered by existing layout tests (even the test I added to fix the original bug showed this problem, I just didn't notice it), sigh.

This is purely a pixel issue, so isn't caught except by pixel layout tests.
Comment 2 Beth Dakin 2007-05-10 16:16:05 PDT
Comment on attachment 14478 [details]
Fix focus rings for continuations to account for collapsing through other blocks when inlines are empty

r=me!
Comment 3 Dave Hyatt 2007-05-10 16:20:04 PDT
Fixed