Bug 136668 - Add support for :read-write/:read-only matching editable content
Summary: Add support for :read-write/:read-only matching editable content
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-09 00:04 PDT by Benjamin Poulain
Modified: 2014-09-09 14:03 PDT (History)
2 users (show)

See Also:

Attachments
Patch (72.32 KB, patch)
2014-09-09 00:23 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-09-09 00:04:10 PDT 
Add support for :read-write/:read-only matching editable content
Comment 1 Benjamin Poulain 2014-09-09 00:23:45 PDT 
Created attachment 237843 [details]
Patch
Comment 2 Antti Koivisto 2014-09-09 13:00:04 PDT 
Comment on attachment 237843 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237843&action=review

r=me

> Source/WebCore/rendering/RenderTheme.cpp:843
>  bool RenderTheme::isReadOnlyControl(const RenderObject& o) const

With some more refactoring this could surely be turned into RenderElement& or something mores specific and the type check below eliminated...
Comment 3 Benjamin Poulain 2014-09-09 14:03:54 PDT 
Comment on attachment 237843 [details]
Patch

Clearing flags on attachment: 237843

Committed r173441: <http://trac.webkit.org/changeset/173441>
Comment 4 Benjamin Poulain 2014-09-09 14:03:58 PDT 
All reviewed patches have been landed.  Closing bug.