Getting Below Build error for EFL-WK2 build, since default case is not handled. [ 84%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/Plugins/Netscape/JSNPObject.cpp.o /home/shiva.jm/webkit-git/svngitsep/WebKit/Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.cpp: In function ‘std::chrono::milliseconds WebKit::maximumBufferingTime(WebCore::CachedResource*)’: /home/shiva.jm/webkit-git/svngitsep/WebKit/Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.cpp:115:1: error: control reaches end of non-void function [-Werror=return-type] } ^ cc1plus: all warnings being treated as errors make[2]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/Network/WebResourceLoadScheduler.cpp.o] Error 1
Created attachment 237841 [details] Patch Fix the build error by handling default case.
Comment on attachment 237841 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237841&action=review > Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.cpp:116 > + default: > + return 0_ms; We don’t want a default here, because that will disable the warning that clang and other compilers give us when we forget to handle a case. Instead, we should put this return statement outside the switch, and we should also include ASSERT_NOT_REACHED.
Created attachment 237842 [details] Patch for landing
Comment on attachment 237842 [details] Patch for landing cq=me
Comment on attachment 237842 [details] Patch for landing Clearing flags on attachment: 237842 Committed r173420: <http://trac.webkit.org/changeset/173420>
All reviewed patches have been landed. Closing bug.