Bug 136655 – REGRESSION (r172129): Vine pages load as blank

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Jeff Kelley]

It appears that the current WebKit nightly build (and several prior builds) can’t render pages on Vine. Screenshot of the included URL (https://vine.co/v/Oz7Vlz6EM1d) attached. I’m on 10.9.4 using WebKit in Safari at Version 7.0.6 (9537.78.2, r173400).

[Jeff Kelley]

Created attachment 237829 [details]
A screenshot of the bug.

[Jeff Kelley]

Oddly, if I open up Page Resources with ⌘⌥A, then refresh the page with that open, it works.

[Alexey Proskuryakov]

Regressed in <http://trac.webkit.org/changeset/172129>.

[Alexey Proskuryakov]

<rdar://problem/18281215>

[Filip Pizlo]

Created attachment 237979 [details]
the patch

[Michael Saboff]

Comment on attachment 237979 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237979&action=review

r=me

> Source/JavaScriptCore/dfg/DFGPhantomRemovalPhase.cpp:101
> +                    if (sourceIndex - 1) {

I prefer if (sourceIndex > 1) for readability

[Filip Pizlo]

(In reply to comment #6)
> (From update of attachment 237979 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=237979&action=review
> 
> r=me
> 
> > Source/JavaScriptCore/dfg/DFGPhantomRemovalPhase.cpp:101
> > +                    if (sourceIndex - 1) {
> 
> I prefer if (sourceIndex > 1) for readability

I agree.  Will change.

[Filip Pizlo]

Landed in http://trac.webkit.org/changeset/173534