Bug 136655 - REGRESSION (r172129): Vine pages load as blank
Summary: REGRESSION (r172129): Vine pages load as blank
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac (Intel) OS X 10.9
: P1 Normal
Assignee: Filip Pizlo
URL: https://vine.co/v/Oz7Vlz6EM1d
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-09-08 18:52 PDT by Jeff Kelley
Modified: 2014-09-11 13:05 PDT (History)
1 user (show)

See Also:

Attachments
A screenshot of the bug. (244.98 KB, image/png)
2014-09-08 18:53 PDT, Jeff Kelley 		no flags Details
the patch (3.45 KB, patch)
2014-09-11 12:34 PDT, Filip Pizlo 		msaboff: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Kelley 2014-09-08 18:52:33 PDT 
It appears that the current WebKit nightly build (and several prior builds) can’t render pages on Vine. Screenshot of the included URL (https://vine.co/v/Oz7Vlz6EM1d) attached. I’m on 10.9.4 using WebKit in Safari at Version 7.0.6 (9537.78.2, r173400).
Comment 1 Jeff Kelley 2014-09-08 18:53:17 PDT 
Created attachment 237829 [details]
A screenshot of the bug.
Comment 2 Jeff Kelley 2014-09-08 18:55:04 PDT 
Oddly, if I open up Page Resources with ⌘⌥A, then refresh the page with that open, it works.
Comment 3 Alexey Proskuryakov 2014-09-09 12:42:14 PDT 
Regressed in <http://trac.webkit.org/changeset/172129>.
Comment 4 Alexey Proskuryakov 2014-09-09 12:42:34 PDT 
<rdar://problem/18281215>
Comment 5 Filip Pizlo 2014-09-11 12:34:01 PDT 
Created attachment 237979 [details]
the patch
Comment 6 Michael Saboff 2014-09-11 12:47:09 PDT 
Comment on attachment 237979 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237979&action=review

r=me

> Source/JavaScriptCore/dfg/DFGPhantomRemovalPhase.cpp:101
> +                    if (sourceIndex - 1) {

I prefer if (sourceIndex > 1) for readability
Comment 7 Filip Pizlo 2014-09-11 12:53:18 PDT 
(In reply to comment #6)
> (From update of attachment 237979 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=237979&action=review
> 
> r=me
> 
> > Source/JavaScriptCore/dfg/DFGPhantomRemovalPhase.cpp:101
> > +                    if (sourceIndex - 1) {
> 
> I prefer if (sourceIndex > 1) for readability

I agree.  Will change.
Comment 8 Filip Pizlo 2014-09-11 13:05:00 PDT 
Landed in http://trac.webkit.org/changeset/173534